Skip to content

Debug ASAN with clang on ARM #1690

Closed
rustam-gamidov-here wants to merge 13 commits intomasterfrom
rga/ocmam-447-deploy-boost-json-test-asan
Closed

Debug ASAN with clang on ARM #1690
rustam-gamidov-here wants to merge 13 commits intomasterfrom
rga/ocmam-447-deploy-boost-json-test-asan

Conversation

@rustam-gamidov-here
Copy link
Copy Markdown
Collaborator

No description provided.

rustam-gamidov-here and others added 12 commits March 30, 2026 10:17
To catch issues in this kind of build earlier

Relates-To: OCMAM-442

Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Patch boost::json 1.82 with BOOST_NO_EXCEPTIONS
Is is solved in boost::json 1.83 but we preferred to stay at 1.82

Relates-To: OCMAM-442

Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Good to be able to do this. No tests as not exposed classes are
accessed in tests.
Examples: export functions from libs to utilize in the common binary

Make boost::json header only in the read lib
Otherwise there are unresolved external symbols when built with
visibility=hidden

Relates-To: MINOR
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON

Relates-To: OCMAM-443
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
It appeared that Clang and GCC complains on different lines
at least in case of Boost  codebase

Relates-To: MINOR

Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON

Relates-To: OCMAM-443

Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON
Copy json implementation wrappers to write lib

This allows to keep other libs untouched until fully migrated to the
boost::json and remove write lib dependency from public json wrappers.
Alternative solutions tried are:
 - add boost json wrappers to the same files in the core but to
   additional namespace - changes in core, json still exposed
 - move boost json wrappers from core to internal for the repository
   include location and add it to all DataSDK projects - huge change

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON
Copy json implementation wrappers to read lib

This allows to keep other libs untouched until fully migrated to the
boost::json and remove read lib dependency from public json wrappers.
Alternative solutions tried are:
 - add boost json wrappers to the same files in the core but to
   additional namespace - changes in core, json still exposed
 - move boost json wrappers from core to internal for the repository
   include location and add it to all DataSDK projects - huge change

Relates-To: OCMAM-444
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON
Json wrappers has been moved and not exposed anymore
Use Boost::json in mock-server-client
Use boost::json in HarCaptureAdapter

Relates-To: OCMAM-446
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating to boost::json

Relates-To: OCMAM-447
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Boost date_time has no 'no_exception' setup and clang is compiling
that code even if it's not used. GCC is OK

Relates-To: OCMAM-447
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 75.64470% with 255 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.31%. Comparing base (b400ee0) to head (6dc1a96).

Files with missing lines Patch % Lines
...p-sdk-core/src/http/adapters/HarCaptureAdapter.cpp 0.00% 144 Missing ⚠️
...dk-authentication/src/AuthenticationClientImpl.cpp 73.68% 23 Missing and 7 partials ⚠️
...-cpp-sdk-core/src/generated/parser/ParserWrapper.h 27.78% 12 Missing and 1 partial ⚠️
...e/src/generated/serializer/IndexInfoSerializer.cpp 68.97% 7 Missing and 2 partials ⚠️
...erated/serializer/UpdateIndexRequestSerializer.cpp 75.00% 6 Missing and 2 partials ⚠️
...k-authentication/src/AuthenticationClientUtils.cpp 75.86% 1 Missing and 6 partials ⚠️
...rvice-read/src/repositories/PartitionsSaxHandler.h 70.83% 7 Missing ⚠️
...ataservice-read/src/repositories/QuadTreeIndex.cpp 84.62% 2 Missing and 4 partials ⚠️
olp-cpp-sdk-authentication/src/BaseResult.cpp 68.75% 1 Missing and 4 partials ⚠️
...p-sdk-authentication/src/ResponseFromJsonBuilder.h 78.95% 1 Missing and 3 partials ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
- Coverage   80.42%   80.31%   -0.11%     
==========================================
  Files         351      356       +5     
  Lines       14221    14279      +58     
  Branches     1544     1564      +20     
==========================================
+ Hits        11437    11468      +31     
- Misses       2156     2181      +25     
- Partials      628      630       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/ocmam-447-deploy-boost-json-test-asan branch 2 times, most recently from 4c9b427 to 00ab424 Compare April 8, 2026 09:34
Debug ASAN

Relates-To: OCMAM-447
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@rustam-gamidov-here rustam-gamidov-here force-pushed the rga/ocmam-447-deploy-boost-json-test-asan branch from 00ab424 to 6dc1a96 Compare April 8, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants