Skip to content

Skip analytics init on apps without persistent token store #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BilalG1 merged 4 commits into from
Apr 14, 2026
Merged

Skip analytics init on apps without persistent token store #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db4d275
Skip analytics init on apps without persistent token store
BilalG1 Apr 14, 2026
9e88e38
Merge branch 'dev' into analytics-access-token-issue-fix
BilalG1 Apr 14, 2026
cdb0a0c
skip feedback tests on local emulator
BilalG1 Apr 14, 2026
bb858d1
Merge remote-tracking branch 'origin/dev' into analytics-access-token…
BilalG1 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/e2e/tests/backend/endpoints/api/v1/internal/feedback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ import { describe } from "vitest";
import { it } from "../../../../../helpers";
import { Auth, backendContext, createMailbox, niceBackendFetch, waitForOutboxEmailWithStatus } from "../../../../backend-helpers";

const isLocalEmulator = process.env.NEXT_PUBLIC_STACK_IS_LOCAL_EMULATOR === "true";
Comment thread
BilalG1 marked this conversation as resolved.

describe("POST /api/v1/internal/feedback", () => {
it("should send feedback from an authenticated user", async ({ expect }) => {
it.runIf(!isLocalEmulator)("should send feedback from an authenticated user", async ({ expect }) => {
const senderEmail = backendContext.value.mailbox.emailAddress;
const signInResult = await Auth.Otp.signIn();
const recipientMailbox = createMailbox("team@stack-auth.com");
Expand Down Expand Up @@ -44,7 +46,7 @@ describe("POST /api/v1/internal/feedback", () => {
expect(messages[0].body?.text).toContain("Authenticated feedback from the dashboard.");
});

it("should send feedback without authentication (dev tool)", async ({ expect }) => {
it.runIf(!isLocalEmulator)("should send feedback without authentication (dev tool)", async ({ expect }) => {
const recipientMailbox = createMailbox("team@stack-auth.com");
const senderEmail = `devtool-user-${randomUUID()}@example.com`;
const subject = `[Support] ${senderEmail}`;
Expand Down Expand Up @@ -81,7 +83,7 @@ describe("POST /api/v1/internal/feedback", () => {
expect(messages[0].body?.text).toContain("Unauthenticated feedback from the dev tool.");
});

it("should send bug reports with correct label", async ({ expect }) => {
it.runIf(!isLocalEmulator)("should send bug reports with correct label", async ({ expect }) => {
const recipientMailbox = createMailbox("team@stack-auth.com");
const reporterEmail = `bug-${randomUUID()}@example.com`;
const subject = `[Bug Report] ${reporterEmail}`;
Expand Down
4 changes: 2 additions & 2 deletions packages/template/src/lib/stack-app/apps/implementations/client-app-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ export class _StackClientAppImplIncomplete<HasTokenStore extends boolean, Projec
return anonUser._internalSession;
};

if (isBrowserLike() && this._analyticsOptions?.replays?.enabled === true) {
if (isBrowserLike() && this._hasPersistentTokenStore() && this._analyticsOptions?.replays?.enabled === true) {
this._sessionRecorder = new SessionRecorder({
projectId: this.projectId,
sendBatch: async (body, opts) => {
Expand All @@ -573,7 +573,7 @@ export class _StackClientAppImplIncomplete<HasTokenStore extends boolean, Projec
this._sessionRecorder.start();
}

if (isBrowserLike()) {
if (isBrowserLike() && this._hasPersistentTokenStore()) {
this._eventTracker = new EventTracker({
projectId: this.projectId,
sendBatch: async (body, opts) => {
Expand Down
Loading