Skip to content

fix(dashboard): collapsed email editor height; sandbox email-preview iframes #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BilalG1 merged 2 commits into from
May 4, 2026
+9 −2
Merged

fix(dashboard): collapsed email editor height; sandbox email-preview iframes #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca21867
fix(dashboard): give vibe-code editor a definite height; sandbox emai…
BilalG1 May 4, 2026
cc41443
fix(dashboard): allow scripts in email-preview iframes
BilalG1 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/dashboard/src/components/email-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ function EmailPreviewContent({

return (
<iframe
sandbox="allow-scripts"
srcDoc={inertPreviewHtml}
className="w-full h-full border-0"
title="Email Preview"
Expand Down Expand Up @@ -692,6 +693,7 @@ function EmailPreviewEditableContent({

return (
<iframe
sandbox="allow-scripts"
ref={iframeRef}
srcDoc={editableHtml}
className="w-full h-full border-0"
Expand Down
9 changes: 7 additions & 2 deletions apps/dashboard/src/components/vibe-coding/vibe-code-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ export default function VibeCodeLayout({
return (
<TooltipProvider delayDuration={300}>
{/* Mobile Layout - visible on small screens, hidden on md+ */}
<div className="flex flex-col h-full w-full overflow-hidden md:hidden">
{/* h-[calc(100dvh-3.5rem)] anchors to viewport (minus sticky header) so the
editor doesn't depend on an unbroken h-full chain through the dashboard
shell, which collapses because <main> doesn't stretch (items-start). */}
<div className="flex flex-col h-[calc(100dvh-3.5rem)] w-full overflow-hidden md:hidden">
{/* Mobile Header - Compact */}
<div className="px-3 pt-3 pb-2 shrink-0">
<div className="flex flex-col gap-2">
Expand Down Expand Up @@ -354,7 +357,9 @@ export default function VibeCodeLayout({
</div>

{/* Desktop/Tablet Layout - hidden on small screens, visible on md+ */}
<div className="hidden md:flex flex-col h-full w-full overflow-hidden">
{/* See note on the mobile wrapper above; the dark-mode header is taller
(floating card with mt-3/mb-3 padding), matching sidebar-layout.tsx. */}
<div className="hidden md:flex flex-col h-[calc(100vh-3.5rem)] dark:h-[calc(100vh-6rem)] w-full overflow-hidden">
<div className="flex-1 overflow-hidden flex flex-col">
{/* Top Header / Toolbar - with consistent inset spacing */}
<div className="px-6 pt-4 pb-3">
Expand Down
Loading