Skip to content

fix(tests): use sql.json in onboarding migration test and refresh metrics snapshot #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mantrakp04 wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(tests): use sql.json in onboarding migration test and refresh metrics snapshot #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e72e498
fix(tests): use sql.json in onboarding migration test and refresh met…
mantrakp04 May 6, 2026
ca17a11
fix(tests): cast onboardingState to jsonb in migration test
mantrakp04 May 7, 2026
9f37134
Merge branch 'dev' into fix/onboarding-migration-test-and-metrics-sna…
mantrakp04 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...risma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
};
await sql`
UPDATE "Project"
SET "onboardingState" = ${JSON.stringify(onboardingState)}::jsonb
SET "onboardingState" = ${sql.json(onboardingState)}::jsonb
Copy link
Copy Markdown

@vercel vercel Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SET "onboardingState" = ${sql.json(onboardingState)}::jsonb
SET "onboardingState" = ${sql.json(onboardingState)}

Unnecessary ::jsonb cast applied after sql.json() function in migration test UPDATE statement causes inconsistency with other migration tests

Fix on Vercel

WHERE "id" = ${ctx.projectId}
`;

Expand All @@ -39,7 +39,7 @@
WHERE "id" = ${ctx.projectId}
`;
expect(updatedRows).toHaveLength(1);
expect(JSON.parse(updatedRows[0].onboardingState)).toMatchInlineSnapshot(`

Check failure on line 42 in apps/backend/prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts

View workflow job for this annotation

GitHub Actions / Back-compat — Current branch migrations with dev branch code

src/auto-migrations/migration-tests.test.ts > database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 

Error: Snapshot `database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 1` mismatched

- Expected
+ Received

- {
-   "selected_apps": [
-     "authentication",
-     "emails",
-   ],
-   "selected_config_choice": "create-new",
-   "selected_email_theme_id": null,
-   "selected_payments_country": "US",
-   "selected_sign_in_methods": [
-     "credential",
-     "magicLink",
-   ],
- }
+ "{"selected_config_choice":"create-new","selected_apps":["authentication","emails"],"selected_sign_in_methods":["credential","magicLink"],"selected_email_theme_id":null,"selected_payments_country":"US"}"

 ❯ Module.postMigration prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts:42:54
 ❯ src/auto-migrations/migration-tests.test.ts:148:13

Check failure on line 42 in apps/backend/prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts

View workflow job for this annotation

GitHub Actions / Back-compat — Current branch migrations with dev branch code

src/auto-migrations/migration-tests.test.ts > database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 

Error: Snapshot `database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 1` mismatched

- Expected
+ Received

- {
-   "selected_apps": [
-     "authentication",
-     "emails",
-   ],
-   "selected_config_choice": "create-new",
-   "selected_email_theme_id": null,
-   "selected_payments_country": "US",
-   "selected_sign_in_methods": [
-     "credential",
-     "magicLink",
-   ],
- }
+ "{"selected_config_choice":"create-new","selected_apps":["authentication","emails"],"selected_sign_in_methods":["credential","magicLink"],"selected_email_theme_id":null,"selected_payments_country":"US"}"

 ❯ Module.postMigration prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts:42:54
 ❯ src/auto-migrations/migration-tests.test.ts:148:13

Check failure on line 42 in apps/backend/prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts

View workflow job for this annotation

GitHub Actions / Forward-compat — Current branch code with dev branch migrations

src/auto-migrations/migration-tests.test.ts > database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 

Error: Snapshot `database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 1` mismatched

- Expected
+ Received

- {
-   "selected_apps": [
-     "authentication",
-     "emails",
-   ],
-   "selected_config_choice": "create-new",
-   "selected_email_theme_id": null,
-   "selected_payments_country": "US",
-   "selected_sign_in_methods": [
-     "credential",
-     "magicLink",
-   ],
- }
+ "{"selected_config_choice":"create-new","selected_apps":["authentication","emails"],"selected_sign_in_methods":["credential","magicLink"],"selected_email_theme_id":null,"selected_payments_country":"US"}"

 ❯ Module.postMigration prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts:42:54
 ❯ src/auto-migrations/migration-tests.test.ts:148:13

Check failure on line 42 in apps/backend/prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts

View workflow job for this annotation

GitHub Actions / Forward-compat — Current branch code with dev branch migrations

src/auto-migrations/migration-tests.test.ts > database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 

Error: Snapshot `database migration tests > 20260420000000_add_project_onboarding_state > default-and-updates 1` mismatched

- Expected
+ Received

- {
-   "selected_apps": [
-     "authentication",
-     "emails",
-   ],
-   "selected_config_choice": "create-new",
-   "selected_email_theme_id": null,
-   "selected_payments_country": "US",
-   "selected_sign_in_methods": [
-     "credential",
-     "magicLink",
-   ],
- }
+ "{"selected_config_choice":"create-new","selected_apps":["authentication","emails"],"selected_sign_in_methods":["credential","magicLink"],"selected_email_theme_id":null,"selected_payments_country":"US"}"

 ❯ Module.postMigration prisma/migrations/20260420000000_add_project_onboarding_state/tests/default-and-updates.ts:42:54
 ❯ src/auto-migrations/migration-tests.test.ts:148:13
{
"selected_apps": [
"authentication",
Expand Down
4 changes: 2 additions & 2 deletions apps/e2e/tests/backend/endpoints/api/v1/__snapshots__/internal-metrics.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2435,15 +2435,15 @@ NiceResponse {
"display_name": null,
"id": "<stripped UUID>",
"last_active_at_millis": <stripped field 'last_active_at_millis'>,
"primary_email": "mailbox-1--<stripped UUID>@stack-generated.example.com",
"primary_email": "mailbox-2--<stripped UUID>@stack-generated.example.com",
"profile_image_url": null,
"signed_up_at_millis": <stripped field 'signed_up_at_millis'>,
},
{
"display_name": null,
"id": "<stripped UUID>",
"last_active_at_millis": <stripped field 'last_active_at_millis'>,
"primary_email": "mailbox-2--<stripped UUID>@stack-generated.example.com",
"primary_email": "mailbox-1--<stripped UUID>@stack-generated.example.com",
"profile_image_url": null,
"signed_up_at_millis": <stripped field 'signed_up_at_millis'>,
},
Expand Down
Loading