Skip to content

Add 3.11-dev support#847

Merged
davfsa merged 8 commits intohikari-py:masterfrom
FasterSpeeding:task/3-11
Sep 21, 2022
Merged

Add 3.11-dev support#847
davfsa merged 8 commits intohikari-py:masterfrom
FasterSpeeding:task/3-11

Conversation

@FasterSpeeding
Copy link
Copy Markdown
Contributor

@FasterSpeeding FasterSpeeding commented Oct 15, 2021

Summary

Add 3.11 support

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

@FasterSpeeding FasterSpeeding marked this pull request as draft October 15, 2021 03:11
davfsa
davfsa previously approved these changes Oct 15, 2021
View reviewed changes
@davfsa
Copy link
Copy Markdown
Member

davfsa commented Oct 15, 2021 •
edited
Loading

Looks like yarl is not yet python 3.11 compatible, maybe worth opening an issue there

Edit: Sorry, didnt see it was a draft

@FasterSpeeding
Copy link
Copy Markdown
Contributor Author

FasterSpeeding commented Oct 16, 2021

Edit: Sorry, didnt see it was a draft

Lol its fine, fun fact it automatically requested a review from you cause you're also a code owner of the stuff this is changing so I couldn't avoid that (well I might've been able to if I opened this as draft but it was opened as a normal PR to make sure that the actions actually run on it).

@FasterSpeeding
Copy link
Copy Markdown
Contributor Author

FasterSpeeding commented Oct 16, 2021

maybe worth opening an issue there

And will do

@FasterSpeeding FasterSpeeding deleted the task/3-11 branch October 20, 2021 04:21
@FasterSpeeding FasterSpeeding restored the task/3-11 branch October 20, 2021 04:21
@davfsa
Copy link
Copy Markdown
Member

davfsa commented Nov 21, 2021

Waiting on warner/python-ed25519#16

@davfsa
Copy link
Copy Markdown
Member

davfsa commented Dec 16, 2021

We might have to setup a fork for python-ed25519, as it doesn't look like the PR is getting merged any time soon unfortunately

@davfsa
Copy link
Copy Markdown
Member

davfsa commented Jan 29, 2022

ed25519 dependency removed by #986, unblocking this pr and hopefully can be merged after a rebase

@FasterSpeeding FasterSpeeding force-pushed the task/3-11 branch 2 times, most recently from e6b3b31 to b66d511 Compare February 3, 2022 16:48
@davfsa
Copy link
Copy Markdown
Member

davfsa commented Feb 3, 2022 •
edited
Loading

For some context on the tests breaking, this is due to aiohttp and yarl not using the latest cython version, which fixes those bugs. We will have to wait for the next release then

Relevant PRs: aio-libs/aiohttp#6396 and aio-libs/yarl#654

@FasterSpeeding
Copy link
Copy Markdown
Contributor Author

FasterSpeeding commented Feb 3, 2022

For some context on the tests breaking, this is due to aiohttp and yarl not using the latest cython version, which fixes those bugs. We will have to wait for the next release then

Relevant PRs: aio-libs/aiohttp#6396 and aio-libs/yarl#654

I'm aware, I'm just messing around with stuff to see if i can get it to run in the pipelines by just installing from source to see if anything does break cause i'm bored (but this has turned into too much effort so given up on the idea)

@davfsa
Copy link
Copy Markdown
Member

davfsa commented Feb 3, 2022 •
edited
Loading

I'm aware, I'm just messing around with stuff to see if i can get it to run in the pipelines by just installing from source to see if anything does break cause i'm bored (but this has turned into too much effort so given up on the idea)

Was just leaving it for prosperity and anybody that stumbles upon this :P

@FasterSpeeding FasterSpeeding force-pushed the task/3-11 branch 2 times, most recently from c913906 to a8a4d3c Compare March 25, 2022 20:59
@UnknownLITE
Copy link
Copy Markdown

UnknownLITE commented Jul 16, 2022 •
edited
Loading

Python 3.11.0b4 is now available, and
Python.org strongly encourage maintainers of third-party Python projects to test with 3.11 during the beta phase and report issues found to the Python bug tracker as soon as possible

Maybe it is irrelevant for this project idk

@davfsa
Copy link
Copy Markdown
Member

davfsa commented Jul 16, 2022 •
edited
Loading

Python 3.11.0b4 is now available, and
Python.org strongly encourage maintainers of third-party Python projects to test with 3.11 during the beta phase and report issues found to the Python bug tracker as soon as possible

Maybe it is irrelevant for this project idk

We have been trying to test CPython 3.11 for some time now (reason for this pr), but the dependencies of hikari don't support 3.11 yet, so we can't yet as it fails to build

@davfsa
Copy link
Copy Markdown
Member

davfsa commented Sep 21, 2022

Aiohttp 3.8.3 just released and it has full support for Python 3.11.

We can bump aiohttp to that minimum version and then (hopefully) this pr can be merged with python 3.11 support!

@davfsa davfsa closed this Sep 21, 2022
@davfsa davfsa reopened this Sep 21, 2022
@davfsa
Copy link
Copy Markdown
Member

davfsa commented Sep 21, 2022

Just re-triggering CI

@davfsa davfsa added devops Changes to quality control processes, CI, release processes skip-fragment-check Skip fragment checks for this PR as it doesnt need one and removed skip-fragment-check Skip fragment checks for this PR as it doesnt need one labels Sep 21, 2022
@davfsa
Copy link
Copy Markdown
Member

davfsa commented Sep 21, 2022

cchardet was dropped as a speedup for aiohttp (< python 3.10) in this version too due to it being unmaintained.

There have been talks about a replacement, but no outcome yet. Best bet would be to just install aiohttp[speedups]~=same version as requirements to prevent this from happening in the future.

The links for speedups should also have to be updated to just point to the aiohttp docs to see what packages are being installed on top

@davfsa davfsa marked this pull request as ready for review September 21, 2022 21:42
@davfsa davfsa enabled auto-merge (squash) September 21, 2022 21:44
@davfsa davfsa disabled auto-merge September 21, 2022 21:50
@davfsa davfsa merged commit 3009cda into hikari-py:master Sep 21, 2022
@davfsa davfsa mentioned this pull request Sep 21, 2022
Merged
2 tasks
@FasterSpeeding FasterSpeeding deleted the task/3-11 branch November 13, 2022 09:14
Forbidden-A pushed a commit to Forbidden-A/hikari that referenced this pull request Jun 8, 2025
@FasterSpeeding @davfsa @Forbidden-A
Add 3.11-dev support (hikari-py#847)
b29f4a4 
Co-authored-by: davfsa <davfsa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davfsa davfsa davfsa approved these changes

Assignees

No one assigned

Labels

devops Changes to quality control processes, CI, release processes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FasterSpeeding @davfsa @UnknownLITE