iaqualink: enable _attr_has_entity_name#167810
Merged
joostlek merged 6 commits intohome-assistant:devfrom Apr 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the iAqualink integration’s base entity to opt into Home Assistant’s “entity name” naming model and adjusts tests accordingly.
Changes:
- Enable entity-name semantics for all iAqualink entities via the base
AqualinkEntityclass. - Extend the iAqualink setup test to assert
EntityRegistryEntry.has_entity_nameis set for created entities. - Make the assumed/available test resilient to entity_id generation by using the created entity_id from state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/components/iaqualink/entity.py |
Sets _attr_has_entity_name = True on the iAqualink base entity class. |
tests/components/iaqualink/test_init.py |
Adds entity-registry assertions for has_entity_name and avoids hardcoding the light entity_id in one test. |
36deec5 to
5aa7840
Compare
fab3462 to
fd42088
Compare
fd42088 to
94779dd
Compare
joostlek
requested changes
Apr 14, 2026
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
joostlek
approved these changes
Apr 14, 2026
21 tasks
zxdavb
pushed a commit
to zxdavb/hass
that referenced
this pull request
Apr 14, 2026
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Set _attr_has_entity_name on AqualinkEntity base class.
Fix hardcoded entity names in tests.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: