Skip to content

iaqualink: enable _attr_has_entity_name#167810

Merged
joostlek merged 6 commits intohome-assistant:devfrom
flz:iaqualink-has-entity-name
Apr 14, 2026
Merged

iaqualink: enable _attr_has_entity_name#167810
joostlek merged 6 commits intohome-assistant:devfrom
flz:iaqualink-has-entity-name

Conversation

@flz
Copy link
Copy Markdown
Contributor

@flz flz commented Apr 9, 2026

Breaking change

Proposed change

Set _attr_has_entity_name on AqualinkEntity base class.
Fix hardcoded entity names in tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the iAqualink integration’s base entity to opt into Home Assistant’s “entity name” naming model and adjusts tests accordingly.

Changes:

  • Enable entity-name semantics for all iAqualink entities via the base AqualinkEntity class.
  • Extend the iAqualink setup test to assert EntityRegistryEntry.has_entity_name is set for created entities.
  • Make the assumed/available test resilient to entity_id generation by using the created entity_id from state.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/iaqualink/entity.py Sets _attr_has_entity_name = True on the iAqualink base entity class.
tests/components/iaqualink/test_init.py Adds entity-registry assertions for has_entity_name and avoids hardcoding the light entity_id in one test.

Comment thread homeassistant/components/iaqualink/entity.py Outdated
Comment thread tests/components/iaqualink/test_init.py
@flz flz force-pushed the iaqualink-has-entity-name branch from 36deec5 to 5aa7840 Compare April 10, 2026 19:38
Copilot AI review requested due to automatic review settings April 10, 2026 20:24
@flz flz changed the title iaqualink: enable _attr_entity_name iaqualink: enable _has_attr_entity_name Apr 10, 2026
@flz flz changed the title iaqualink: enable _has_attr_entity_name iaqualink: enable _attr_has_entity_name Apr 10, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/iaqualink/entity.py
Copilot AI review requested due to automatic review settings April 10, 2026 20:43
@flz flz force-pushed the iaqualink-has-entity-name branch from fab3462 to fd42088 Compare April 10, 2026 20:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Comment thread homeassistant/components/iaqualink/entity.py
Comment thread homeassistant/components/iaqualink/switch.py Outdated
Comment thread homeassistant/components/iaqualink/sensor.py Outdated
Comment thread homeassistant/components/iaqualink/light.py Outdated
Comment thread homeassistant/components/iaqualink/climate.py Outdated
Comment thread homeassistant/components/iaqualink/binary_sensor.py Outdated
@flz flz force-pushed the iaqualink-has-entity-name branch from fd42088 to 94779dd Compare April 10, 2026 21:56
@flz flz marked this pull request as ready for review April 10, 2026 21:59
Copilot AI review requested due to automatic review settings April 10, 2026 21:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comment thread homeassistant/components/iaqualink/entity.py
@home-assistant home-assistant Bot marked this pull request as draft April 14, 2026 14:29
@home-assistant
Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Copilot AI review requested due to automatic review settings April 14, 2026 15:36
@flz flz marked this pull request as ready for review April 14, 2026 15:36
@home-assistant home-assistant Bot requested a review from joostlek April 14, 2026 15:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@joostlek joostlek merged commit 8695d32 into home-assistant:dev Apr 14, 2026
36 of 37 checks passed
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Apr 14, 2026
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants