Victron GX switch platform by tomer-w · Pull Request #167859 · home-assistant/core

tomer-w · 2026-04-10T05:38:23Z

Proposed change

Adding switch platform for Victron GX integration

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add switch platform doc home-assistant.io#44609
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…_binary_sensor

…_switch

Copilot

Pull request overview

Adds a new switch entity platform to the Victron GX integration so writable “switch” metrics (e.g., EV charger start/stop) are exposed as Home Assistant switch entities with translations and tests.

Changes:

Add SwitchEntity implementation and discovery wiring for MetricKind.SWITCH.
Register the switch platform in the integration’s platform list.
Add entity name translations and new switch-focused tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`homeassistant/components/victron_gx/__init__.py`	Adds `Platform.SWITCH` so config entries set up the new platform.
`homeassistant/components/victron_gx/switch.py`	Implements switch entity discovery, state updates, and on/off commands for writable switch metrics.
`homeassistant/components/victron_gx/strings.json`	Adds switch entity translation keys/names used by the new platform.
`tests/components/victron_gx/test_switch.py`	Introduces tests covering switch creation, updates, and service calls.

erwindouna · 2026-04-10T06:57:04Z

Wasn't this recently closed, due too much PRs are being submitted and first ones need to be merged?

#167780

tomer-w · 2026-04-10T07:00:18Z

Wasn't this recently closed, due too much PRs are being submitted and first ones need to be merged?

#167780

Yes, and I did get 2 platforms merged so I'm moving to the next set.

erwindouna

Shouldn't we also cover faulty situations? For instance if toggle failed to update raise a Home assistant error?

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

tomer-w · 2026-04-10T08:01:44Z

@erwindouna, thanks for the quick review. I fix all comments.

tomer-w · 2026-04-10T09:05:22Z

Shouldn't we also cover faulty situations? For instance if toggle failed to update raise a Home assistant error?

@erwindouna , the update is just sending mqtt message. I have no idea if the other side actually got it. When they do get it they change another topic which will actually change the switch position but theoretically that message can get for state change for other reasons.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

tomer-w · 2026-04-10T14:46:34Z

@erwindouna, thanks for your review. Can you mark it as approved by you?

erwindouna

Looks good to me, thanks @tomer-w!

NoRi2909 · 2026-04-10T17:31:41Z

+        "name": "Relay on Multi RS state"
+      },
+      "solarcharger_relay_state": {
+        "name": "Relay state"
+      },
+      "switch_output_state": {
+        "name": "Switch {output} state"
+      },
+      "switchable_output_output_state": {
+        "name": "Switchable output {output} state"
+      },


Noticed this while translating: We should drop "state" from these entities as this results in really clumsy translations. In many languages you cannot simply place 4 nouns in a row, so this has to be reworded as

State of switchable output X : On

But you would just say something like "Switchable output X is on", and not "The state of (the) switchable output X is on". Thus those entities work just fine as:

Switchable output X : On

Shortening also helps a lot on mobile and with small column widths in general.

@NoRi2909, I will take it to the dedupe PR which I will publish the moment we get all the platforms in. I hope early next week.

tomer-w and others added 11 commits April 6, 2026 17:02

Add binary_sensor platform to victron_gx integration

a104a9d

Add device class support

df157ea

Add switch platform

e3be9a5

Add binary_sensor platform to victron_gx integration

cf7c771

Add device class support

2037cf5

Update homeassistant/components/victron_gx/const.py

73067c8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update homeassistant/components/victron_gx/binary_sensor.py

e74ae30

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'dev' of https://github.com/tomer-w/core into victron_gx…

3c63a0d

…_binary_sensor

Merge branch 'dev' of https://github.com/tomer-w/core into victron_gx…

6b02e46

…_switch

Merge upstream/dev into victron_gx_switch

45d11a7

Fix merge

a574ee6

Copilot AI review requested due to automatic review settings April 10, 2026 05:38

home-assistant Bot added cla-signed has-tests integration: victron_gx new-feature new-platform by-code-owner Quality Scale: bronze labels Apr 10, 2026

Copilot started reviewing on behalf of tomer-w April 10, 2026 05:39 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread tests/components/victron_gx/test_switch.py Outdated

Comment thread tests/components/victron_gx/test_switch.py Outdated

Comment thread homeassistant/components/victron_gx/switch.py Outdated

Comment thread homeassistant/components/victron_gx/switch.py Outdated

tomer-w mentioned this pull request Apr 10, 2026

Add switch platform doc home-assistant/home-assistant.io#44609

Merged

8 tasks

fix cr comments

1dc3041

erwindouna requested changes Apr 10, 2026

View reviewed changes

fix CR comments

3cc3b35

Copilot AI review requested due to automatic review settings April 10, 2026 07:49

Copilot started reviewing on behalf of tomer-w April 10, 2026 07:49 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread homeassistant/components/victron_gx/strings.json

Comment thread homeassistant/components/victron_gx/strings.json Outdated

Comment thread homeassistant/components/victron_gx/strings.json Outdated

fix merge

1d4fa63

tomer-w requested a review from erwindouna April 10, 2026 08:02

move to async

3a254b0

Copilot AI review requested due to automatic review settings April 10, 2026 10:33

Copilot started reviewing on behalf of tomer-w April 10, 2026 10:33 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread tests/components/victron_gx/test_switch.py Outdated

Comment thread homeassistant/components/victron_gx/binary_sensor.py Outdated

Update tests/components/victron_gx/test_switch.py

b0d87a1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 10, 2026 10:44

Update homeassistant/components/victron_gx/binary_sensor.py

3b63f31

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of tomer-w April 10, 2026 10:45 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread tests/components/victron_gx/test_switch.py

improve test coverage

fa16e7a

erwindouna requested changes Apr 10, 2026

View reviewed changes

Comment thread tests/components/victron_gx/test_switch.py

tomer-w requested a review from erwindouna April 10, 2026 14:13

joostlek approved these changes Apr 10, 2026

View reviewed changes

joostlek merged commit 547830b into home-assistant:dev Apr 10, 2026
33 checks passed

erwindouna approved these changes Apr 10, 2026

View reviewed changes

NoRi2909 reviewed Apr 10, 2026

View reviewed changes

tomer-w deleted the victron_gx_switch branch April 10, 2026 17:38

github-actions Bot locked and limited conversation to collaborators Apr 11, 2026

Uh oh!

Conversation

tomer-w commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwindouna commented Apr 10, 2026

Uh oh!

tomer-w commented Apr 10, 2026

Uh oh!

erwindouna left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomer-w commented Apr 10, 2026

Uh oh!

tomer-w commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

tomer-w commented Apr 10, 2026

Uh oh!

Uh oh!

erwindouna left a comment

Choose a reason for hiding this comment

Uh oh!

NoRi2909 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

tomer-w Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tomer-w commented Apr 10, 2026 •

edited

Loading