dev: relax config folder convention for subdomains to allow top-level#274
Merged
gildesmarais merged 2 commits intomasterfrom Jan 2, 2026
Merged
dev: relax config folder convention for subdomains to allow top-level#274gildesmarais merged 2 commits intomasterfrom
gildesmarais merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request relaxes the config folder organization convention to allow configs to be placed under registrable domain folders (e.g., example.com/) instead of requiring subdomain-specific folders (e.g., blog.example.com/). The change introduces new helper methods for extracting registrable domains and hosts from URLs, updates validation logic to accept both conventions, and adds the public_suffix gem dependency.
Key changes:
- Added
Helper.url_to_registrable_domainandHelper.url_to_host_namemethods with robust error handling for extracting domain information from URLs - Modified config file validation to accept both registrable domain and full host folder names, supporting the new convention while maintaining backward compatibility
- Added
public_suffixgem for proper handling of multi-part TLDs likeco.uk
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/support/helper.rb | Adds new helper methods for extracting registrable domains and hosts from URLs, with error handling for invalid inputs |
| spec/helper_spec.rb | Adds test coverage for the new URL parsing helper methods with various input scenarios |
| spec/support/shared_examples/config.yml_spec.rb | Updates validation to accept configs in either registrable domain or full host folders, supporting both conventions |
| README.md | Documents the new config folder convention preferring registrable domain folders over subdomain folders |
| Gemfile | Adds public_suffix gem dependency for domain extraction |
| Gemfile.lock | Updates lockfile with public_suffix and its dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new convention for organizing config files by registrable domain, improves helper methods for extracting domains and hosts from URLs, and updates related tests and documentation. The most important changes are:
Domain Extraction & Helper Methods:
Helper.url_to_registrable_domainmethod to extract the registrable domain from a URL, properly handling multi-part TLDs (e.g.,bbc.co.uk) and invalid URLs. Relies on the newpublic_suffixgem. (spec/support/helper.rb,Gemfile,spec/helper_spec.rb) [1] [2] [3]Helper.url_to_host_nameto reliably extract the full host from a URL, with error handling for invalid URLs. (spec/support/helper.rb,spec/helper_spec.rb) [1] [2]Config Organization & Validation:
example.com/), with legacy subdomain folders still supported but not preferred. (README.md)spec/support/shared_examples/config.yml_spec.rb)Testing:
spec/helper_spec.rb)