Skip to content

fix(validation): use runtime config validation entrypoint#288

Merged
gildesmarais merged 6 commits intomasterfrom
codex/align-validation-entrypoint
Mar 14, 2026
Merged

fix(validation): use runtime config validation entrypoint#288
gildesmarais merged 6 commits intomasterfrom
codex/align-validation-entrypoint

Conversation

@gildesmarais
Copy link
Copy Markdown
Member

@gildesmarais gildesmarais commented Mar 10, 2026

Summary

  • switch bin/validate_configs to Html2rss::Config.validate_yaml(file)
  • cover parameterized config validation at the script level
  • load the sibling html2rss checkout in specs so this workspace exercises the shared validation behavior

Why

This script was validating raw YAML directly, which drifted from the runtime parameter-expansion path. Using the gem entrypoint keeps validation behavior aligned with feed execution.


This pull request makes minor updates to the development environment and test setup, ensuring dependencies are correctly sourced and loaded.

  • Dependency management:

    • Updated the Gemfile to use the html2rss-generator gem from the GitHub repository instead of a local path, ensuring consistency with the remote source.
  • Test setup:

    • Added an explicit require 'html2rss' statement in spec/spec_helper.rb to ensure the main library is loaded during tests.

@gildesmarais gildesmarais force-pushed the codex/align-validation-entrypoint branch from 03699b6 to 8eace25 Compare March 14, 2026 12:29
@gildesmarais gildesmarais requested a review from Copilot March 14, 2026 12:37
@gildesmarais gildesmarais merged commit 4e401e6 into master Mar 14, 2026
9 checks passed
@gildesmarais gildesmarais deleted the codex/align-validation-entrypoint branch March 14, 2026 12:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates config validation tooling to use the latest html2rss API and adds a regression test to ensure parameterized configs validate correctly (including defaults).

Changes:

  • Switch bin/validate_configs to use Html2rss::Config.validate_yaml with a compatibility guard for older gem versions.
  • Add an RSpec integration test for validating a parameterized config with defaults.
  • Minor tooling/dependency updates (npm ci in setup, gem revisions/lockfile adjustments).

Reviewed changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/spec_helper.rb Minor formatting adjustment.
spec/bin/validate_configs_spec.rb Adds spec coverage for bin/validate_configs success path with parameter defaults.
bin/validate_configs Moves validation to Config.validate_yaml and adds version guardrails.
bin/setup Uses npm ci for deterministic Node installs.
Gemfile Removes a commented-out local override.
Gemfile.lock Updates pinned git revision and a dependency patch version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants