fix(validation): use runtime config validation entrypoint#288
Merged
gildesmarais merged 6 commits intomasterfrom Mar 14, 2026
Merged
fix(validation): use runtime config validation entrypoint#288gildesmarais merged 6 commits intomasterfrom
gildesmarais merged 6 commits intomasterfrom
Conversation
03699b6 to
8eace25
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates config validation tooling to use the latest html2rss API and adds a regression test to ensure parameterized configs validate correctly (including defaults).
Changes:
- Switch
bin/validate_configsto useHtml2rss::Config.validate_yamlwith a compatibility guard for older gem versions. - Add an RSpec integration test for validating a parameterized config with defaults.
- Minor tooling/dependency updates (
npm ciin setup, gem revisions/lockfile adjustments).
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
spec/spec_helper.rb |
Minor formatting adjustment. |
spec/bin/validate_configs_spec.rb |
Adds spec coverage for bin/validate_configs success path with parameter defaults. |
bin/validate_configs |
Moves validation to Config.validate_yaml and adds version guardrails. |
bin/setup |
Uses npm ci for deterministic Node installs. |
Gemfile |
Removes a commented-out local override. |
Gemfile.lock |
Updates pinned git revision and a dependency patch version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This script was validating raw YAML directly, which drifted from the runtime parameter-expansion path. Using the gem entrypoint keeps validation behavior aligned with feed execution.
This pull request makes minor updates to the development environment and test setup, ensuring dependencies are correctly sourced and loaded.
Dependency management:
Gemfileto use thehtml2rss-generatorgem from the GitHub repository instead of a local path, ensuring consistency with the remote source.Test setup:
require 'html2rss'statement inspec/spec_helper.rbto ensure the main library is loaded during tests.