Conversation
stevhliu
approved these changes
Apr 6, 2026
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
thanks, just one small suggestion!
.ai/modular.md
Outdated
| ```python | ||
| class ChunkDenoiseStep(LoopSequentialPipelineBlocks): | ||
| block_classes = [PrepareChunkStep, NoiseGenStep, DenoiseInnerStep, UpdateStep] | ||
| class HeliosChunkDenoiseStep(LoopSequentialPipelineBlocks): |
Member
There was a problem hiding this comment.
maybe clearer to use the real classes here (HeliosChunkHistorySliceStep, etc.) since you're providing a real class to avoid any confusion
added 2 commits
April 14, 2026 17:38
yiyixuxu
force-pushed
the
modular-pipeline-docs
branch
from
9026d0e to
55ce615
Compare
github-actions
bot
added
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow #13334
moved
model-integrawtion/skillls/modular-conversion.mdto.ai/modular.md, and link it fromAGENTS.md,model-integrawtion/skilllsandreview-rules.mdadded a Gotcha section for modular as well