Open
Conversation
… some paths handling in idfx_test.py
7eaebeb to
f39d6a6
Compare
glesur
requested changes
Mar 29, 2026
Contributor
glesur
left a comment
There was a problem hiding this comment.
a few typos, but otherwise ok
| Overview | ||
| -------- | ||
|
|
||
| The class :doc:`idfxTest <idfxTest>` provides the basement to implement an *Idefix* integration test for validation. |
Contributor
There was a problem hiding this comment.
Suggested change
| The class :doc:`idfxTest <idfxTest>` provides the basement to implement an *Idefix* integration test for validation. | |
| The class :doc:`idfxTest <idfxTest>` provides the toolbox to implement an *Idefix* integration test for validation. |
| Depencencies | ||
| ------------ | ||
|
|
||
| Before using :doc:`idfxTest <idfxTest>` you need to install some Python Depencencies (possibly in a ``virtual env``): |
Contributor
There was a problem hiding this comment.
Suggested change
| Before using :doc:`idfxTest <idfxTest>` you need to install some Python Depencencies (possibly in a ``virtual env``): | |
| Before using :doc:`idfxTest <idfxTest>` you need to install some Python depencencies (possibly in a ``virtual env``): |
| ---------- generated xml file: idefix-tests.junit.xml --------------------------------------------------------- | ||
| =============================== 8 passed, 44 deselected in 73.03s (0:01:13) =================================== | ||
|
|
||
| When seeing an error, the output of the command will be printed at the end. |
Contributor
There was a problem hiding this comment.
Suggested change
| When seeing an error, the output of the command will be printed at the end. | |
| When an error is detected, the output of the command will be printed at the end. |
| Definition of the tests | ||
| ----------------------- | ||
|
|
||
| The script is simply searching all the files names ``testme.json`` into the ``test`` directory. |
Contributor
There was a problem hiding this comment.
Suggested change
| The script is simply searching all the files names ``testme.json`` into the ``test`` directory. | |
| The script looks for all the files named ``testme.json`` in the ``test`` directory and all its sub-directories. |
| ----------------------- | ||
|
|
||
| The script is simply searching all the files names ``testme.json`` into the ``test`` directory. | ||
| This file describe the combination of parameters to use to produce the list of *Idefix* run to perform. |
Contributor
There was a problem hiding this comment.
Suggested change
| This file describe the combination of parameters to use to produce the list of *Idefix* run to perform. | |
| This file describes the combination of parameters used to produce the list of *Idefix* runs to check. |
| } | ||
|
|
||
|
|
||
| By default, the alphabetical order will be used. |
Contributor
There was a problem hiding this comment.
Suggested change
| By default, the alphabetical order will be used. | |
| By default, the alphabetical order is used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
When running locally the full test suite (tests in /test of Idefix) we might want to avoid getting a long log with no summary of what passed and what failed.
What it does
In order a ease running the suite, I implemented a way to call the tests via the pytest library which is used to implement python unit tests. It offers by default :
-k mpi)-v) if desiredjunit2html).testme.json
I provided a way to describe the test running option combinations via a
testme.jsonfile which might be more readableand less programmatic than the current
testme.py.Example:
{ "variants": [ { "dumpname": "dump.0001.dmp", "ini": ["idefix.ini","idefix-rkl.ini"], "noplot": true, "single": [false, true], "reconstruction": 2, "mpi": [false, true], "tolerance": 0 } ] }This PR provides the
testme.jsonequivalent to eachtestme.pyin the test directory.Documentation
I updated the documentation by adding a new dedicated page in
doc/source/testing/testLauncher.rstMissing
Make a default configuration for re-generate the reference results.
Legacy
I currently let untouched the current
testme.pyfiles to let the time to validate and complete the new process.