Skip to content

MNT: upgrade ruff pre-commit hook, move its configuration out of pre-commit-config.yaml and fix lints#371

Open
neutrinoceros wants to merge 5 commits intoidefix-code:developfrom
neutrinoceros:lint/ruff-conf
Open

MNT: upgrade ruff pre-commit hook, move its configuration out of pre-commit-config.yaml and fix lints#371
neutrinoceros wants to merge 5 commits intoidefix-code:developfrom
neutrinoceros:lint/ruff-conf

Conversation

@neutrinoceros
Copy link
Copy Markdown
Collaborator

Moving ruff's config to ruff.toml allows running ruff's LSP in an IDE and see lints before git commit is invoked.
I also upgraded the tool to a much more recent version and applied newly discovered lints.

@neutrinoceros
Copy link
Copy Markdown
Collaborator Author

neutrinoceros commented Apr 2, 2026

Seeing a couple failures with

TypeError: zip() takes no keyword arguments

which indicate that the python interpreter used in CI is older than 3.10.
While I strongly recommend upgrading it at least to 3.111, I could also adjust settings to preserve compatibility with an older Python version, though in this case, please let me know how far back you'd like me to go.

Footnotes

  1. for motivation Python 3.9 is EOL already and 3.10 will be too in about 6 month

@neutrinoceros neutrinoceros changed the base branch from master to develop April 4, 2026 08:43
@neutrinoceros
Copy link
Copy Markdown
Collaborator Author

updated base branch to develop

@glesur
Copy link
Copy Markdown
Contributor

glesur commented Apr 4, 2026

python updated to 3.14 from sources on the self-hosted runner. Should work fine.

@neutrinoceros
Copy link
Copy Markdown
Collaborator Author

thanks. Pre-commit still failed on CI but it looks like some unrelated networking error.

@neutrinoceros
Copy link
Copy Markdown
Collaborator Author

linting passed, but now the env under which tests are run looks broken.

@glesur
Copy link
Copy Markdown
Contributor

glesur commented Apr 7, 2026

tests are failing because somehow #367 is not included upstream. Can you rebase ?

@neutrinoceros
Copy link
Copy Markdown
Collaborator Author

I don't think that's it. I did check that commits from #367 are in my branch's history. In any case rebasing locally turned into a no-op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants