Skip to content

add scf_service_get_pg(3SCF), scf_service_add_pg(3SCF)#2

Open
jgallagher wants to merge 3 commits intoillumos:mainfrom
jgallagher:john/add-service-pg-fns
Open

add scf_service_get_pg(3SCF), scf_service_add_pg(3SCF)#2
jgallagher wants to merge 3 commits intoillumos:mainfrom
jgallagher:john/add-service-pg-fns

Conversation

@jgallagher
Copy link
Copy Markdown

From libscf.h:

int scf_service_get_pg(const scf_service_t *, const char *,
    scf_propertygroup_t *);

int scf_service_add_pg(const scf_service_t *,  const char *, const char *,
    uint32_t, scf_propertygroup_t *);

Comment thread src/native.rs Outdated
out: *mut scf_propertygroup_t,
) -> c_int;
pub fn scf_service_add_pg(
service: *mut scf_service_t,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be *const?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Nice catch - thanks. Fixed both in 4869670

Comment thread src/stubs.rs Outdated
unimplemented!()
}
pub unsafe fn scf_service_add_pg(
service: *mut scf_service_t,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be *const?

@jclulow jclulow changed the title Add scf_service_get_pg() and scf_service_add_pg() add scf_service_get_pg(3SCF), scf_service_add_pg(3SCF) Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants