Skip to content

chore: removed latest tag from v5 #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryamohanan wants to merge 1 commit into
base: v5
Choose a base branch
from
+25 −10
Open

chore: removed latest tag from v5 #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ jobs:
git --no-pager diff --cached
git --no-pager diff
elif [[ $FROM_PACKAGE = true ]]; then
npx lerna publish --yes --no-verify-access from-package
npx lerna publish --dist-tag v5 --yes --no-verify-access from-package
git log -p -n1
else
npx lerna publish --yes --no-verify-access
npx lerna publish --dist-tag v5 --yes --no-verify-access
git log -p -n1
fi

Expand Down
31 changes: 23 additions & 8 deletions packages/serverless/ci/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ resources:
icon: docker
source:
repository: us.icr.io/instana-tracer-nodejs/concourse-dind-nodejs-aws-jq
tag: latest
# NOTE: Deliberately omitting `tag: latest` here on the branch for 5.x so
# we do not accidentally tag 5.x image versions with `latest`.
username: iamapikey
password: ((team-nodejs-ibm-cloud-icr-api-key))

Expand All @@ -47,7 +48,8 @@ resources:
repository: icr.io/instana/aws-fargate-nodejs
username: ((concourse-icr-containers-public.apikey))
password: ((concourse-icr-containers-public.password))
tag: latest
# NOTE: Deliberately omitting `tag: latest` here on the branch for 5.x so
# we do not accidentally tag 5.x image versions with `latest`.

- name: instana-google-cloud-run-npm-package
type: npm-resource
Expand All @@ -65,7 +67,8 @@ resources:
repository: icr.io/instana/google-cloud-run-nodejs
username: ((concourse-icr-containers-public.apikey))
password: ((concourse-icr-containers-public.password))
tag: latest
# NOTE: Deliberately omitting `tag: latest` here on the branch for 5.x so
# we do not accidentally tag 5.x image versions with `latest`.

- name: instana-aws-lambda-npm-package
type: npm-resource
Expand Down Expand Up @@ -98,7 +101,8 @@ resources:
repository: icr.io/instana/azure-container-services-nodejs
username: ((concourse-icr-containers-public.apikey))
password: ((concourse-icr-containers-public.password))
tag: latest
# NOTE: Deliberately omitting `tag: latest` here on the branch for 5.x so
# we do not accidentally tag 5.x image versions with `latest`.

resource_types:

Expand Down Expand Up @@ -171,6 +175,7 @@ jobs:
- put: aws-fargate-nodejs-image-icr
params:
image: image/image.tar
# In fact, on the branch for 5.x, this will be the only tag, not an _additional_ tag.
additional_tags: instana-aws-fargate-npm-package/version
get_params:
skip_download: true
Expand Down Expand Up @@ -258,6 +263,7 @@ jobs:
- put: google-cloud-run-nodejs-image-icr
params:
image: image/image.tar
# In fact, on the branch for 5.x, this will be the only tag, not an _additional_ tag.
additional_tags: instana-google-cloud-run-npm-package/version
get_params:
skip_download: true
Expand Down Expand Up @@ -345,13 +351,15 @@ jobs:
platform: linux
inputs:
- name: nodejs-repository
# Passing in PACKAGE_VERSION=5 will use the latest 5.x package and also avoid tagging the resulting
# container image as latest.
run:
path: entrypoint.sh
args:
- bash
- -ceux
- |
BUILD_LAYER_WITH=npm \
PACKAGE_VERSION=5 \
NO_PROMPT=true \
CONTAINER_REGISTRY_USER=iamapikey \
CONTAINER_REGISTRY_PASSWORD=((concourse-icr-containers-public.password)) \
Expand Down Expand Up @@ -385,13 +393,15 @@ jobs:
platform: linux
inputs:
- name: nodejs-repository
# Passing in PACKAGE_VERSION=5 will use the latest 5.x package and also avoid tagging the resulting
# container image as latest.
run:
path: entrypoint.sh
args:
- bash
- -ceux
- |
BUILD_LAYER_WITH=npm \
PACKAGE_VERSION=5 \
NO_PROMPT=true \
SKIP_DOCKER_IMAGE=true \
LAMBDA_ARCHITECTURE=arm64 \
Expand Down Expand Up @@ -427,13 +437,15 @@ jobs:
platform: linux
inputs:
- name: nodejs-repository
# Passing in PACKAGE_VERSION=5 will use the latest 5.x package and also avoid tagging the resulting
# container image as latest.
run:
path: entrypoint.sh
args:
- bash
- -ceux
- |
BUILD_LAYER_WITH=npm \
PACKAGE_VERSION=5 \
NO_PROMPT=true \
SKIP_DOCKER_IMAGE=true \
PUBLISH_TO_CHINA_REGIONS=true \
Expand Down Expand Up @@ -469,13 +481,15 @@ jobs:
platform: linux
inputs:
- name: nodejs-repository
# Passing in PACKAGE_VERSION=5 will use the latest 5.x package and also avoid tagging the resulting
# container image as latest.
run:
path: entrypoint.sh
args:
- bash
- -ceux
- |
BUILD_LAYER_WITH=npm \
PACKAGE_VERSION=5 \
NO_PROMPT=true \
SKIP_DOCKER_IMAGE=true \
LAMBDA_ARCHITECTURE=arm64 \
Expand Down Expand Up @@ -549,6 +563,7 @@ jobs:
- put: azure-container-services-nodejs-image-icr
params:
image: image/image.tar
# In fact, on the branch for 5.x, this will be the only tag, not an _additional_ tag.
additional_tags: instana-azure-container-services-npm-package/version
get_params:
skip_download: true
Expand Down