[tooling] Separate image-dev from image#1455
Open
BenjaminPelletier wants to merge 5 commits into
Open
Conversation
barroco
approved these changes
May 14, 2026
| docker load --input monitoring-image/monitoring-image.tar | ||
| cp monitoring-image/monitoring/image monitoring/image | ||
| cp monitoring-image/monitoring/image-dev monitoring/image-dev | ||
| touch monitoring/image monitoring/image-dev |
Contributor
There was a problem hiding this comment.
Would be good to echo the creation reason in the file similar to the build scripts
Member
Author
There was a problem hiding this comment.
The files should contain the reasoning -- they actually exist already from the archive and are copied with their content into the local container. The touch is an extra precaution against accidentally rebuilding, but probably isn't needed and could potentially be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1453 by treating the normal image and the dev image separately.
My verification process for the CI side was to check each of the job types and verify that neither the normal image nor the dev image were rebuilt (instead using the images built in "Build monitoring images"). This took some doing to troubleshoot, but I believe these changes also fix a pre-existing problem where images would rebuild after pytests.