Fix: Do not add a newline after the cargo-nextest args#1030
Merged
ipetkov merged 1 commit intoipetkov:masterfrom Apr 28, 2026
Merged
Fix: Do not add a newline after the cargo-nextest args#1030ipetkov merged 1 commit intoipetkov:masterfrom
ipetkov merged 1 commit intoipetkov:masterfrom
Conversation
When overriding the checkPhase and re-using the checkPhaseCargoCommand
from the old mkCargoDerivation definition here, with all of
`cargoExtraArgs`, `cargoNextestExtraArgs` and `moreArgs` empty, the
trailing `\` adds a newline to the cargo-nextest call, which causes
scripts to misbehave in situations like:
RUST_LOG=off ${old.checkPhaseCargoCommand} --custom-arg || somethingElse
With this change, this trailing newline is removed, which makes the
scenario described above work.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Owner
|
The newline should have been escaped but maybe something gets confused with the nesting in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When overriding the checkPhase and re-using the checkPhaseCargoCommand from the old mkCargoDerivation definition here, with all of
cargoExtraArgs,cargoNextestExtraArgsandmoreArgsempty, the trailing\adds a newline to the cargo-nextest call, which causes scripts to misbehave in situations like:With this change, this trailing newline is removed, which makes the scenario described above work.
Motivation
Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md