Skip to content

chore: Update to Ruby v3.3 and jekyll v4.3 #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewfeickert wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: Update to Ruby v3.3 and jekyll v4.3 #2364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2635584
chore: Update Ruby to v3.3
matthewfeickert Aug 8, 2024
cd36197
fix: Add 'csv' and 'base64' gems as won't be in standard gems
matthewfeickert Aug 8, 2024
f5e5195
fix: Appease Rubocop
matthewfeickert Aug 8, 2024
c14c6c9
chore: Incorporate upstream changes from PR #1728 (rebase)
Copilot Apr 23, 2026
9b7f3a4
chore: Update Gemfile.lock to use bundler 2.4.19 and latest gem versions
Copilot Apr 28, 2026
d82ee47
fix: Disable Style/OneClassPerFile and Naming/PredicateMethod RuboCop…
Copilot Apr 28, 2026
7594690
Merge branch 'master' into chore/update-to-ruby-3-3
rct225 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ Metrics/PerceivedComplexity:
Max: 12
Metrics/CyclomaticComplexity:
Max: 12
# Jekyll plugins legitimately define multiple modules/classes in one file
Style/OneClassPerFile:
Enabled: false
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/OneClassPerFile is disabled globally, which will also hide issues outside of Jekyll plugins. Consider scoping this to the plugin code only (e.g., via Exclude: ['_plugins/**/*.rb']) so the cop still applies to the rest of the repository.

Suggested change
Enabled: false
Exclude:
- '_plugins/**/*.rb'

Copilot uses AI. Check for mistakes.
# load_from_cache returns bool as success/failure indicator but also has side effects
Naming/PredicateMethod:
Enabled: false
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling Naming/PredicateMethod for the entire codebase is very broad for a single method (load_from_cache). Prefer a targeted configuration (e.g., allowlist that method in AllowedMethods, or disable the cop only for the specific file/lines) so predicate naming issues elsewhere are still caught.

Suggested change
Enabled: false
AllowedMethods:
- load_from_cache

Copilot uses AI. Check for mistakes.
AllCops:
NewCops: enable
TargetRubyVersion: 3.1
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllCops.TargetRubyVersion is still set to 3.1, but this PR updates the toolchain/lockfile to Ruby 3.3.x. Update TargetRubyVersion to match the new supported Ruby version so RuboCop enables the right parser and rules.

Suggested change
TargetRubyVersion: 3.1
TargetRubyVersion: 3.3

Copilot uses AI. Check for mistakes.
Expand Down
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,7 @@ gem 'webrick'

# Required on Ruby 2.6 (polyfill)
gem 'ruby-next'

# no longer part of the default gems in Ruby v3.4.0+
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says these gems are needed because they are not default gems in Ruby 3.4+, but this PR is targeting Ruby 3.3.x. If the intent is future-proofing for 3.4+, consider clarifying the comment (or making the dependency conditional on Ruby >= 3.4) to avoid confusion about why they’re being added now.

Suggested change
# no longer part of the default gems in Ruby v3.4.0+
# Added for compatibility with Ruby 3.4+, where these are no longer default gems.
# Keeping them here is harmless on earlier supported Ruby versions as well.

Copilot uses AI. Check for mistakes.
gem 'base64' # required by safe_yaml
gem 'csv' # required by Jekyll
Comment on lines +67 to +69
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gemfile still declares ruby '>= 3.1.0', but this PR updates the Pixi environment and lockfile to Ruby 3.3.3. Consider bumping the Gemfile Ruby requirement to the same minimum (or otherwise reconciling the supported Ruby versions) to avoid confusing/unsupported Bundler setups.

Copilot uses AI. Check for mistakes.
217 changes: 124 additions & 93 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,73 +4,89 @@ GEM
Ascii85 (2.0.1)
addressable (2.9.0)
public_suffix (>= 2.0.2, < 8.0)
afm (0.2.2)
ast (2.4.2)
async (2.23.0)
afm (1.0.0)
ast (2.4.3)
async (2.37.0)
console (~> 1.29)
fiber-annotation
io-event (~> 1.9)
io-event (~> 1.11)
metrics (~> 0.12)
traces (~> 0.15)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.9)
traces (~> 0.18)
base64 (0.3.0)
benchmark (0.5.0)
bigdecimal (3.3.1)
colorator (1.1.0)
concurrent-ruby (1.3.5)
console (1.29.3)
concurrent-ruby (1.3.6)
console (1.34.3)
fiber-annotation
fiber-local (~> 1.1)
json
csv (3.3.2)
diff-lcs (1.6.0)
csv (3.3.5)
diff-lcs (1.6.2)
em-websocket (0.5.3)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0)
ethon (0.16.0)
ethon (0.18.0)
ffi (>= 1.15.0)
logger
eventmachine (1.2.7)
ffi (1.17.1-aarch64-linux-gnu)
ffi (1.17.1-aarch64-linux-musl)
ffi (1.17.1-arm-linux-gnu)
ffi (1.17.1-arm-linux-musl)
ffi (1.17.1-arm64-darwin)
ffi (1.17.1-x86_64-darwin)
ffi (1.17.1-x86_64-linux-gnu)
ffi (1.17.1-x86_64-linux-musl)
ffi (1.17.4-aarch64-linux-gnu)
ffi (1.17.4-aarch64-linux-musl)
ffi (1.17.4-arm-linux-gnu)
ffi (1.17.4-arm-linux-musl)
ffi (1.17.4-arm64-darwin)
ffi (1.17.4-x86-linux-gnu)
ffi (1.17.4-x86-linux-musl)
ffi (1.17.4-x86_64-darwin)
ffi (1.17.4-x86_64-linux-gnu)
ffi (1.17.4-x86_64-linux-musl)
fiber-annotation (0.2.0)
fiber-local (1.1.0)
fiber-storage
fiber-storage (1.0.0)
fiber-storage (1.0.1)
forwardable-extended (2.6.0)
google-protobuf (4.29.3)
google-protobuf (4.34.1)
bigdecimal
rake (>= 13)
google-protobuf (4.29.3-aarch64-linux)
rake (~> 13.3)
google-protobuf (4.34.1-aarch64-linux-gnu)
bigdecimal
rake (>= 13)
google-protobuf (4.29.3-arm64-darwin)
rake (~> 13.3)
google-protobuf (4.34.1-aarch64-linux-musl)
bigdecimal
rake (>= 13)
google-protobuf (4.29.3-x86_64-darwin)
rake (~> 13.3)
google-protobuf (4.34.1-arm64-darwin)
bigdecimal
rake (>= 13)
google-protobuf (4.29.3-x86_64-linux)
rake (~> 13.3)
google-protobuf (4.34.1-x86-linux-gnu)
bigdecimal
rake (>= 13)
rake (~> 13.3)
google-protobuf (4.34.1-x86-linux-musl)
bigdecimal
rake (~> 13.3)
google-protobuf (4.34.1-x86_64-darwin)
bigdecimal
rake (~> 13.3)
google-protobuf (4.34.1-x86_64-linux-gnu)
bigdecimal
rake (~> 13.3)
google-protobuf (4.34.1-x86_64-linux-musl)
bigdecimal
rake (~> 13.3)
hashery (2.1.2)
html-proofer (5.0.10)
html-proofer (5.2.1)
addressable (~> 2.3)
async (~> 2.1)
benchmark (~> 0.5)
nokogiri (~> 1.13)
pdf-reader (~> 2.11)
rainbow (~> 3.0)
typhoeus (~> 1.3)
yell (~> 2.0)
zeitwerk (~> 2.5)
http_parser.rb (0.8.0)
i18n (1.14.7)
http_parser.rb (0.8.1)
i18n (1.14.8)
concurrent-ruby (~> 1.0)
io-event (1.9.0)
io-event (1.11.2)
jekyll (4.4.1)
addressable (~> 2.4)
base64 (~> 0.2)
Expand Down Expand Up @@ -104,140 +120,155 @@ GEM
jekyll (>= 3.8, < 5.0)
jekyll-watch (2.2.1)
listen (~> 3.0)
json (2.10.2)
kramdown (2.5.1)
rexml (>= 3.3.9)
json (2.19.4)
kramdown (2.5.2)
rexml (>= 3.4.4)
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
language_server-protocol (3.17.0.4)
language_server-protocol (3.17.0.5)
lint_roller (1.1.0)
liquid (4.0.4)
listen (3.9.0)
listen (3.10.0)
logger
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
logger (1.6.6)
logger (1.7.0)
mercenary (0.4.0)
metrics (0.12.1)
metrics (0.15.0)
mini_portile2 (2.8.9)
minima (2.5.2)
jekyll (>= 3.5, < 5.0)
jekyll-feed (~> 0.9)
jekyll-seo-tag (~> 2.1)
nokogiri (1.19.1-aarch64-linux-gnu)
nokogiri (1.19.3)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.19.1-aarch64-linux-musl)
nokogiri (1.19.3-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.19.1-arm-linux-gnu)
nokogiri (1.19.3-aarch64-linux-musl)
racc (~> 1.4)
nokogiri (1.19.1-arm-linux-musl)
nokogiri (1.19.3-arm-linux-gnu)
racc (~> 1.4)
nokogiri (1.19.1-arm64-darwin)
nokogiri (1.19.3-arm-linux-musl)
racc (~> 1.4)
nokogiri (1.19.1-x86_64-darwin)
nokogiri (1.19.3-arm64-darwin)
racc (~> 1.4)
nokogiri (1.19.1-x86_64-linux-gnu)
nokogiri (1.19.3-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.19.1-x86_64-linux-musl)
nokogiri (1.19.3-x86_64-linux-gnu)
racc (~> 1.4)
nokogiri (1.19.3-x86_64-linux-musl)
racc (~> 1.4)
paco (0.2.3)
parallel (1.26.3)
parser (3.3.7.1)
parallel (1.28.0)
parser (3.3.11.1)
ast (~> 2.4.1)
racc
pathutil (0.16.2)
forwardable-extended (~> 2.6)
pdf-reader (2.14.1)
pdf-reader (2.15.1)
Ascii85 (>= 1.0, < 3.0, != 2.0.0)
afm (~> 0.2.1)
afm (>= 0.2.1, < 2)
hashery (~> 2.0)
ruby-rc4
ttfunk
pkg-config (1.6.0)
pkg-config (1.6.5)
prism (1.9.0)
public_suffix (7.0.5)
racc (1.8.1)
rainbow (3.1.1)
rake (13.2.1)
rake (13.4.2)
rb-fsevent (0.11.2)
rb-inotify (0.11.1)
ffi (~> 1.0)
regexp_parser (2.10.0)
require-hooks (0.2.2)
rexml (3.4.2)
rouge (4.5.1)
rubocop (1.73.1)
regexp_parser (2.12.0)
require-hooks (0.3.0)
rexml (3.4.4)
rouge (4.7.0)
rubocop (1.86.1)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parallel (>= 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.38.0, < 2.0)
rubocop-ast (>= 1.49.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.38.1)
parser (>= 3.3.1.0)
rubocop-ast (1.49.1)
parser (>= 3.3.7.2)
prism (~> 1.7)
rubocop-rake (0.7.1)
lint_roller (~> 1.1)
rubocop (>= 1.72.1)
ruby-next (1.1.1)
ruby-next (1.2.0)
paco (~> 0.2)
require-hooks (~> 0.2)
ruby-next-core (= 1.1.1)
ruby-next-core (= 1.2.0)
ruby-next-parser (>= 3.4.0.2)
unparser (~> 0.6.0)
ruby-next-core (1.1.1)
ruby-next-core (1.2.0)
ruby-next-parser (3.4.0.2)
parser (>= 3.0.3.1)
ruby-progressbar (1.13.0)
ruby-rc4 (0.1.5)
safe_yaml (1.0.5)
sass-embedded (1.85.1-aarch64-linux-gnu)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-aarch64-linux-musl)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-arm-linux-gnueabihf)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-arm-linux-musleabihf)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-arm64-darwin)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-x86_64-darwin)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-x86_64-linux-gnu)
google-protobuf (~> 4.29)
sass-embedded (1.85.1-x86_64-linux-musl)
google-protobuf (~> 4.29)
sass-embedded (1.99.0)
google-protobuf (~> 4.31)
rake (>= 13)
sass-embedded (1.99.0-aarch64-linux-gnu)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-aarch64-linux-musl)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-arm-linux-gnueabihf)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-arm-linux-musleabihf)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-arm64-darwin)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-x86_64-darwin)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-x86_64-linux-gnu)
google-protobuf (~> 4.31)
sass-embedded (1.99.0-x86_64-linux-musl)
google-protobuf (~> 4.31)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
traces (0.15.2)
traces (0.18.2)
ttfunk (1.8.0)
bigdecimal (~> 3.1)
typhoeus (1.4.1)
ethon (>= 0.9.0)
typhoeus (1.6.0)
ethon (>= 0.18.0)
unicode-display_width (2.6.0)
unparser (0.6.15)
diff-lcs (~> 1.3)
parser (>= 3.3.0)
webrick (1.9.1)
webrick (1.9.2)
yell (2.2.2)
zeitwerk (2.7.2)
zeitwerk (2.7.5)

PLATFORMS
aarch64-linux
aarch64-linux-gnu
aarch64-linux-musl
arm-linux
arm-linux-gnu
arm-linux-gnueabihf
arm-linux-musl
arm-linux-musleabihf
arm64-darwin
x86-linux
x86-linux-gnu
x86-linux-musl
x86_64-darwin
x86_64-linux
x86_64-linux-gnu
x86_64-linux-musl

DEPENDENCIES
base64
benchmark
csv
html-proofer
jekyll
jekyll-feed
Expand All @@ -256,7 +287,7 @@ DEPENDENCIES
webrick

RUBY VERSION
ruby 3.4.1p0
ruby 3.3.3p89

BUNDLED WITH
2.6.5
2.4.19
Loading
Loading