openUri method implementation (W3C client)

Author: itnelo

CHANGELOG.md

@@ -20,7 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `WebDriverFactory` as a shortcut for driver instantiation.
 - `Timeout\Interceptor` to prevent unresolved (hanging) driver promises, whenever it fails
 (using [reactphp/promise-timer](https://github.com/reactphp/promise-timer)).
-- `ClientInterface::createSession()` method implementation (opening Selenium hub session to interact with remote
+- `ClientInterface::createSession()` method implementation (opening a Selenium hub session to interact with remote
 browser instance).
 
 This early development version doesn't yet contain full implementation for the introduced `WebDriverInterface`, only

src/Client/W3CClient.php

@@ -269,9 +269,41 @@ public function setActiveTab(string $sessionIdentifier, string $tabIdentifier):
      */
     public function openUri(string $sessionIdentifier, string $uri): PromiseInterface
     {
-        // TODO: Implement openUri() method.
+        $requestUri = sprintf(
+            'http://%s:%d/wd/hub/session/%s/url',
+            $this->_options['server']['host'],
+            $this->_options['server']['port'],
+            $sessionIdentifier
+        );
 
-        return reject(new RuntimeException('Not implemented.'));
+        $requestHeaders = [
+            'Content-Type' => 'application/json; charset=UTF-8',
+        ];
+
+        $requestContents = json_encode(['url' => $uri]);
+
+        $responsePromise = $this->httpClient->post($requestUri, $requestHeaders, $requestContents);
+
+        $navigationPromise = $responsePromise
+            ->then(
+                function (ResponseInterface $response) {
+                    $responseBody = (string) $response->getBody();
+
+                    // todo: locate an error message or set it as "undefined error"
+                    if ('{"value":null}' !== $responseBody) {
+                        throw new RuntimeException('URI navigation is not confirmed.');
+                    }
+                }
+            )
+            ->then(
+                null,
+                function (Throwable $rejectionReason) {
+                    throw new RuntimeException('Unable to open an URI (request).', 0, $rejectionReason);
+                }
+            )
+        ;
+
+        return $navigationPromise;
     }
 
     /**

src/SeleniumHubDriver.php

@@ -22,6 +22,7 @@
 use Symfony\Component\OptionsResolver\Exception\ExceptionInterface as ConfigurationExceptionInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use function React\Promise\reject;
+use function React\Promise\resolve;
 
 /**
  * Sends action requests to the Selenium Grid server (hub) and controls their async execution
@@ -172,9 +173,9 @@ public function setActiveTab(string $sessionIdentifier, string $tabIdentifier):
      */
     public function openUri(string $sessionIdentifier, string $uri): PromiseInterface
     {
-        // TODO: Implement openUri() method.
+        $navigationPromise = $this->hubClient->openUri($sessionIdentifier, $uri);
 
-        return reject(new RuntimeException('Not implemented.'));
+        return $this->timeoutInterceptor->applyTimeout($navigationPromise, 'Unable to complete an open URI command.');
     }
 
     /**

src/Timeout/Interceptor.php

@@ -17,6 +17,7 @@
 
 use React\EventLoop\LoopInterface;
 use React\Promise\PromiseInterface;
+use React\Promise\Timer\TimeoutException;
 use RuntimeException;
 use Throwable;
 use function React\Promise\Timer\timeout;
@@ -69,7 +70,14 @@ public function applyTimeout(
         $timedPromise = $timedPromise->then(
             null,
             function (Throwable $rejectionReason) use ($rejectionMessage) {
-                throw new RuntimeException($rejectionMessage, 0, $rejectionReason);
+                if (!$rejectionReason instanceof TimeoutException) {
+                    throw $rejectionReason;
+                }
+
+                $promiseTimerExceptionMessage = $rejectionReason->getMessage();
+                $timeoutRejectionMessage      = sprintf('%s %s.', $rejectionMessage, $promiseTimerExceptionMessage);
+
+                throw new RuntimeException($timeoutRejectionMessage);
             }
         );
 

src/WebDriverFactory.php

@@ -108,8 +108,8 @@ function (OptionsResolver $commandOptionsResolver) {
                             'Maximum time to wait (in seconds) for command execution '
                             . '(do not correlate with HTTP timeouts)'
                         )
-                        ->allowedTypes('int')
-                        ->default(30)
+                        ->allowedTypes('float')
+                        ->default(30.0)
                     ;
                 }
             )
@@ -121,7 +121,7 @@ function (OptionsResolver $commandOptionsResolver) {
         $httpClient      = new Browser($loop, $socketConnector);
 
         // Selenium hub sends some valid responses with 5xx status codes, so we need to disable eager promise rejection
-        // to properly parse error message and other details from the body.
+        // to properly parse error messages and other details from the body.
         $httpClient = $httpClient->withRejectErrorResponse(false);
 
         $hubClient          = new W3CClient($httpClient, ['server' => $optionsResolved['hub']]);