Prevent the repetition of the propagate_callbacks warning#33
Open
FrancoisPgm wants to merge 2 commits intojeremiedbb:base_callbacks_2from
Open
Prevent the repetition of the propagate_callbacks warning#33FrancoisPgm wants to merge 2 commits intojeremiedbb:base_callbacks_2from
FrancoisPgm wants to merge 2 commits intojeremiedbb:base_callbacks_2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes what was raised in scikit-learn#28760 (comment)
Prevent the warning raised in
propagate_callbacksto be repeated during the lifetime of the root context of the task tree. It only works when not using parallelization. I don't see how it could be done in that case unless we add an explicit method for the check in the mixin, to be called during fit before the parallelization happen. And even then it would only work for one level of parallelized nesting.I can also add a dummy pipeline class to the test utils and modify the test of the warning to verify it's only raised once, but I'm wondering if it's worth it.