visual mode re-highlight fix#55
Open
elbeardmorez wants to merge 1 commit intojunegunn:masterfrom
Open
Conversation
elbeardmorez
force-pushed
the
vis_hl_fix
branch
from
635136d to
48e02df
Compare
Author
|
I had to return to the issue again after my buffers started disappearing 😄 Some disbelief that it appeared fixed with the previous change potentially setting the wrong window to the peekaboo buffer too. |
-switching from and then back to the peekaboo buffer via multiple `wincmd p` operations fails if the intermediate `gv + redraw` happens to trigger plugins which visit other windows -instead, record window number and reset following the operations -bug likely went unnoticed because the side-effects of latter buffer modifications aren't that noticeable. however, should the multiple `wincmd p` operations land you on a window with its buffer's `modifiable=0` set, then a very visible: `E21: Cannot make changes,'modifiable' is off` error is presented, and the operation a user is attempting (e.g. "+y etc.) fails ..then you know about it!
elbeardmorez
force-pushed
the
vis_hl_fix
branch
from
48e02df to
b11e58f
Compare
Author
|
Updated commit message with a more palatable explanation - disabling vim-gitgutter makes this issue disappear for me. Hence the dilemma, should peekaboo rely on window order not changing, and complain that gitgutter doesn't restore state after its work is done? Or should peekaboo be slightly more defensive?! Thanks for this plugin regardless of your decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-switching from and then back to the peekaboo buffer via multiple
wincmd poperations fails if the intermediategv + redrawhappensto trigger plugins which visit other windows
-instead, record window number and reset following the operations
-bug likely went unnoticed because the side-effects of latter
buffer modifications aren't that noticeable. however, should the
multiple
wincmd poperations land you on a window with its buffer'smodifiable=0set, then a very visible:E21: Cannot make changes,'modifiable' is offerror is presented, and the operation a user is attempting (e.g.
"+y etc.) fails ..then you know about it!