Skip to content

[WIP] Rewrite tests#54

Draft
ptt-homme wants to merge 3 commits intokdabir:masterfrom
ptt-homme:rewrite-tests
Draft

[WIP] Rewrite tests#54
ptt-homme wants to merge 3 commits intokdabir:masterfrom
ptt-homme:rewrite-tests

Conversation

@ptt-homme
Copy link
Copy Markdown
Contributor

This PR has as base branch (#53), I'll rebase it on master as soon as #53 is merged.

@kdabir
Copy link
Copy Markdown
Owner

kdabir commented Apr 25, 2021

Hey Sorry for the long gap. I have merged #53. Let me know once this is done, will merge it.

Also, reg -V i would much prefer lowercase (-v). Is there any specific reason you chose uppercase V? I could think of using it as inverse of --quiet as -v, --verbose but wanted to confirm.

@ptt-homme
Copy link
Copy Markdown
Contributor Author

Hey, no problems! Thanks for #53.

I'm also a bit busy at the moment, but i'll try to find spare time to finish this.

For "v" or "V", let me know which is the best for you and i'll update it!

@kdabir
Copy link
Copy Markdown
Owner

kdabir commented Apr 30, 2021

I would prefer lowercase -v as that is arguably more common (depends on ecosystem oone is coming from).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants