Kevinjqliu/3.14#40
Conversation
Co-authored-by: Copilot <copilot@github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Python 3.14 to the project classifiers and updates the Ray test fixture to disable automatic environment propagation when running tests via uv. The feedback suggests removing a redundant local os import and recommends retaining the explicit working_dir: None configuration in ray.init as a safeguard against automatic directory serialization in other environments.
| @pytest.fixture(scope="session") | ||
| def ray_session() -> Generator[Any, None, None]: | ||
| """Fixture to manage Ray initialization and shutdown for tests.""" | ||
| import os |
There was a problem hiding this comment.
The os module is already imported at the top of the file (line 28). This local import is redundant and should be removed to maintain code cleanliness.
| ray.init( | ||
| ignore_reinit_error=True, | ||
| runtime_env={"working_dir": None}, # Prevent Ray from serializing the working directory to workers | ||
| ) |
There was a problem hiding this comment.
While the new environment variable RAY_ENABLE_UV_RUN_RUNTIME_ENV handles the uv run specific issue, it is safer to retain the explicit runtime_env={"working_dir": None} configuration. This serves as a general safeguard to prevent Ray from automatically serializing the local working directory in other environments where it might still attempt to do so.
| ) | |
| runtime_env={"working_dir": None}, # Prevent Ray from serializing the working directory to workers | |
| ) |
2 participants
Rationale for this change
Are these changes tested?
Are there any user-facing changes?