Skip to content

try 1.11.0 rc1#42

Open
kevinjqliu wants to merge 3 commits into
mainfrom
kevinjqliu/test-iceberg-rc
Open

try 1.11.0 rc1#42
kevinjqliu wants to merge 3 commits into
mainfrom
kevinjqliu/test-iceberg-rc

Conversation

@kevinjqliu
Copy link
Copy Markdown
Owner

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Iceberg version to 1.11 and introduces a configurable Maven mirror for Iceberg JARs. The reviewer recommends using the full semantic version 1.11.0 for proper artifact resolution and suggests defaulting the mirror URL to the standard Maven repository instead of hardcoding a staging URL to improve maintainability.

Comment thread dev/spark/Dockerfile Outdated
# Dependency versions - keep these compatible
# Changing these will invalidate the JAR download cache layer
ARG ICEBERG_VERSION=1.10.1
ARG ICEBERG_VERSION=1.11
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version 1.11 appears to be incomplete given the PR title "try 1.11.0 rc1". Apache Iceberg typically follows semantic versioning (x.y.z). If this is for the 1.11.0 release candidate, the version should likely be 1.11.0 to correctly resolve the artifact paths in the Maven repository.

ARG ICEBERG_VERSION=1.11.0

Comment thread dev/spark/Dockerfile Outdated
Comment on lines +27 to +28
# ARG ICEBERG_MAVEN_MIRROR=${MAVEN_MIRROR}
ARG ICEBERG_MAVEN_MIRROR=https://repository.apache.org/content/repositories/orgapacheiceberg-1278
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding a specific staging repository URL makes the Dockerfile less flexible and harder to maintain once the release is finalized. It is better to define ICEBERG_MAVEN_MIRROR with a default value pointing to the standard mirror and override it via a build argument (--build-arg) when testing release candidates.

ARG ICEBERG_MAVEN_MIRROR=${MAVEN_MIRROR}

Co-authored-by: Copilot <copilot@github.com>
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/test-iceberg-rc branch from f8cc523 to b819d4b Compare May 8, 2026 18:38
kevinjqliu and others added 2 commits May 8, 2026 15:20
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant