fix: use SameSite=None for embed cookie#743
Merged
Merged
Conversation
In order for the cookie to be set on Keyman for Windows embed keyboard search, we need SameSite=None, because otherwise Chromium will block it as a cross-site cookie, due to the the embed being in an iframe. Relates-to: keymanapp/keyman#15957 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
May 18, 2026
| // | ||
| // Note: 'SameSite=None; secure' is required for embedding in Keyman | ||
| // Configuration for Windows because that uses an iframe to embed the search | ||
| setcookie('embed_keyboards_no_locale_redirect', '1', ["secure" => true, "samesite" => 'None', 'path' => '/']); |
Contributor
There was a problem hiding this comment.
ah, this uses a different casing from ll 3-4?
session_set_cookie_params(["SameSite" => "None"]); // Allow use in iframe, needed for Download Keyboards dialog
session_set_cookie_params(["Secure" => "true"]); // None requires Secure to be set
Member
Author
There was a problem hiding this comment.
yeah seems slightly different, but PHP appears not to care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for the cookie to be set on Keyman for Windows embed keyboard search, we need SameSite=None, because otherwise Chromium will block it as a cross-site cookie, due to the the embed being in an iframe.
Relates-to: keymanapp/keyman#15957
Test-bot: skip