chore: merge staging to master (launch epic/web-i18n)#746
Merged
Conversation
…b17s1 chore: Merge master to staging for Sprint B17S1
…a18s15 chore: Merge master to staging for Sprint A18S15
chore: mid-sprint merge of master to staging for A18S16
chore: Merge master to staging for Sprint A18S20
Merge master to staging for beginning of Sprint B18S1
…-to-staging-b18s2
…b18s2 chore: Merge master to staging for Sprint B18S2
…b18s3 chore: merge master to staging for Sprint B18S3
…-to-staging-b18s4
…-b18s4 chore: Merge master to staging for Sprint B18S4
chore: Merge master to staging for Sprint B18S5
Similar to keymanapp/help.keyman.com#2013 on help.keyman-staging.com
fix: Disallow all bots since staging site doesn't need to be indexed
…a19s1 chore: Merge master to staging for Sprint A19S1
…-to-staging-a19s2
…a19s2 chore: Merge master to staging for Sprint A19S2
…-to-staging-a18s3
…a18s3 chore: Merge master to staging for Sprint A19S3
…a19s9 chore: Merge master to staging for Sprint A19S9
…a19s10 chore: Merge master to staging for Sprint A19S10
…staging cherrypick: epic/i18n-url-scheme to staging
…staging auto: A19S28 merge master into staging
Keyman 14.0 - 18.0 have a dependency on /keyboards which means that we cannot rewrite URLs there when we are in 'embed' mode for those apps. The apps check if the URL starts with /keyboards, and handle those paths internally, while opening other URLs in an external browser. See keymanapp/keyman#15948 for platform-specific dependencies on this behaviour and for v19.0 planned mitigations. Also remove _ie_thunk and _legacy from .htaccess as these are no longer required following removal of pre-Keyman-13.0 support. Relates-to: keymanapp/keyman#15948
fix: rewrite /keyboards for embed mode and skip localization
fix: allow broken-link-checker to run on staging site
fix: set embed_keyboards_no_locale_redirect for entire domain
…-landings fix: Check embed for "new search" and dedicated landing pages
Add locales.json with the list of available locales and language names, update Locale.php to read that, and build a preprocess stage for .htaccess to leverage that single source of truth for supported locales. Test-bot: skip
feat: centralize supported locales and rebuild .htaccess with @Locale
fix globe button regex to ignore /_test/ folder 🌋
In order for the cookie to be set on Keyman for Windows embed keyboard search, we need SameSite=None, because otherwise Chromium will block it as a cross-site cookie, due to the the embed being in an iframe. Relates-to: keymanapp/keyman#15957 Test-bot: skip
fix: use SameSite=None for embed cookie
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
May 19, 2026
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
will do a smoke test...
| # This bot is too busy (300K+ visits/month across all keyman.com domains) | ||
| User-agent: TurnitinBot | ||
| # Disallow all bots since we don't need anything indexed on the staging site | ||
| User-agent: * |
Contributor
There was a problem hiding this comment.
I think robots.txt we just add the bits to allow broken-link-checker to the existing file?
(remove the "Disallow all bots...") cause that was just for staging
Member
Author
There was a problem hiding this comment.
Restoring the version from master; the broken-link-checker is then allowed to run by default anyway
darcywong00
approved these changes
May 19, 2026
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
yeah the site and keyboard search is working
can cleanup robots.txt and TODO.md
| 3. rewrite for .md would embed the lang parameter and the appropriate _content path also. | ||
|
|
||
| * Fixup absolute links in _content/ files to relative links | ||
| * Fixup absolute links in header files to relative links (make a helper function?) |
Contributor
There was a problem hiding this comment.
wonder if we clean this up / move to wiki?
Member
Author
There was a problem hiding this comment.
pulling this out of the PR and adding to issue #747, will review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip