fix(core): clone state deep copy#15947
Open
rc-swag wants to merge 5 commits into
Open
Conversation
This commit update the state object to have a deep copy for the action_struct member. The tests have been modified but have a few issues however this branch is out of date with the refacted master branch for unit tests. This commit gets the main change in a future commit will update the tests.
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
rc-swag
changed the base branch from
master
to
fix/windows/15857/caps-indicator-switched-off-select
rc-swag
changed the title
rc-swag
requested review from
ermshiperete,
mcdurdin and
sgschantz
and removed request for
mcdurdin
keymanapp-test-bot
Bot
removed
the
user-test-missing
mcdurdin
approved these changes
May 18, 2026
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM; note that the test will be a bit painful to merge with epic/web-core because that has the gtest rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api call
km_core_state_clonewhich uses the copy constructor for the state which performed a shallow copy of_action_struct.This would cause a free to be called on allready freed memory when disposing of the clone state object. This was discovered when updating the code to intialise the
_action_structin the constructor of the state class.This change adds adds a deep copy and adds helper functions to actions, and options class to achieve the copy.
Adds test assertions verifying that original and cloned states have independent
action_structvalues.In review of this it was noted there was an existing issue with
_actionslist. Theactions->optionsare going to be point to the the original_option_items_stackvector. In practice this is unlikely to cause problems because_actionscleared and rebuilt on the nextkm_core_process_eventcall. I made the change to the core code this PR#15961 however it needs unit testing for it to be complete.The unit test tests the clone call. It is not currenlty in used in implmentation therefore there are no manual tests available.
Test-bot: skip