Skip to content

Add apidiscovery_definitions.json to docker image#297

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
tomplus:fix/apidiscovery-definitions-docker
Feb 10, 2026
Merged

Add apidiscovery_definitions.json to docker image#297
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
tomplus:fix/apidiscovery-definitions-docker

Conversation

@tomplus
Copy link
Copy Markdown
Member

@tomplus tomplus commented Feb 10, 2026

This new file apidiscovery_definitions.json, with the API Discovery definitions, has to be added to allow generating clients from the docker image.

Now it crashes:

Traceback (most recent call last):
  File "//preprocess_spec.py", line 611, in <module>
    sys.exit(main())
  File "//preprocess_spec.py", line 605, in main
    out_spec = process_swagger(in_spec, args.client_language, crd_mode)
  File "//preprocess_spec.py", line 239, in process_swagger
    spec = add_apidiscovery_definitions(spec)
  File "//preprocess_spec.py", line 179, in add_apidiscovery_definitions
    with open(APIDISCOVERY_DEFINITIONS_PATH, 'r') as apidiscovery_file:
FileNotFoundError: [Errno 2] No such file or directory: '//apidiscovery_definitions.json'

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2026
@tomplus
Copy link
Copy Markdown
Member Author

tomplus commented Feb 10, 2026

@brendandburns could you take a look? thanks

/cc brendandburns
/cc yliaog
/cc copilot

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@tomplus: GitHub didn't allow me to assign the following users: copilot.

Note that only kubernetes-client members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

@brendandburns could you take a look? thanks

/assign brendandburns
/assign yliaog
/assign copilot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tomplus
Copy link
Copy Markdown
Member Author

tomplus commented Feb 10, 2026

/cc brendandburns
/cc yliaog
/cc copilot

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Feb 10, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomplus, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 46c5b51 into kubernetes-client:master Feb 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants