feat: add liveness probe for node-driver-registrar#2400
Conversation
Add health check endpoint and liveness probe for the node-driver-registrar container in the blob CSI driver node DaemonSet. This helps detect and recover from node-driver-registrar failures automatically. Uses port 29637 for the health check endpoint. Since the node DaemonSet always uses hostNetwork: true, the endpoint binds to localhost directly. Changes: - charts/latest: add --http-endpoint arg, ports, and livenessProbe to node-driver-registrar container template - charts/latest/values.yaml: add nodeDriverRegistrar config section - charts/README.md: document new helm values - deploy/csi-blob-node.yaml: add healthcheck to static manifest - Update helm chart tgz
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
There was a problem hiding this comment.
Pull request overview
Adds a dedicated HTTP health endpoint and liveness probe for the node-driver-registrar sidecar in the Blob CSI Driver node DaemonSet, improving automatic recovery from registrar failures in both the static manifests and Helm chart.
Changes:
- Configure
node-driver-registrarwith--http-endpoint=localhost:<port>(default29637). - Add
ports+livenessProbefornode-driver-registrarin both Helm and the static node DaemonSet manifest. - Expose new Helm values (
nodeDriverRegistrar.*) and document them.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
deploy/csi-blob-node.yaml |
Adds registrar HTTP endpoint flag, port, and liveness probe to the static node DaemonSet manifest. |
charts/README.md |
Documents the new nodeDriverRegistrar.* Helm values for the registrar liveness probe. |
charts/latest/blob-csi-driver/values.yaml |
Introduces default nodeDriverRegistrar health port and probe tuning values. |
charts/latest/blob-csi-driver/templates/csi-blob-node.yaml |
Adds registrar HTTP endpoint flag, named port, and livenessProbe to the Helm-rendered node DaemonSet. |
charts/latest/blob-csi-driver-v0.0.0.tgz |
Updates the packaged “latest” chart artifact to include the new template/values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move top-level nodeDriverRegistrar values to node.nodeDriverRegistrar for consistency with existing node.* config structure (node.livenessProbe, node.resources.nodeDriverRegistrar, etc). - values.yaml: nodeDriverRegistrar -> node.nodeDriverRegistrar - csi-blob-node.yaml: .Values.nodeDriverRegistrar -> .Values.node.nodeDriverRegistrar - README.md: update parameter paths - Regenerate charts/latest tgz
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add health check endpoint and liveness probe for the node-driver-registrar container in the blob CSI driver node DaemonSet. This helps detect and recover from node-driver-registrar failures automatically.
Similar to kubernetes-sigs/azuredisk-csi-driver#3572 for azuredisk and kubernetes-sigs/azurefile-csi-driver#3070 for azurefile.
Uses port 29637 for the health check endpoint. Since the node DaemonSet always uses
hostNetwork: true, the endpoint binds to localhost directly.Changes:
charts/latest/templates/csi-blob-node.yaml: add--http-endpointarg, ports, and livenessProbe to node-driver-registrar containercharts/latest/values.yaml: addnodeDriverRegistrarconfig section (healthPort: 29637)charts/README.md: document new helm valuesdeploy/csi-blob-node.yaml: add healthcheck to static manifestWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Port 29637 chosen to avoid conflicts with existing ports (29632 controller liveness, 29633 node liveness, 29634 controller metrics, 29635 node metrics).