fix: eliminate all build warnings#9
Open
Oppen wants to merge 1 commit intofix/lake-test-driverfrom
Open
Conversation
CompletenessSpec.lean: add `omit [...] in` modifiers before the 10 private/public theorems that don't use all section variables (NodeOps, BEq, Hashable, LawfulBEq, LawfulHashable). Tests/IntegrationTests.lean: remove stale simp arguments (NodeOps.children, NodeOps.replaceChildren, NodeOps.mapChildren, hlen) from replaceChildren_children and replaceChildren_sameShape instance proofs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LambdaSat/CompletenessSpec.lean: addsomit [...] inmodifiers before 10 theorems that don't need all section variables (NodeOps,BEq,Hashable,LawfulBEq,LawfulHashable), eliminating 7 → 0unusedSectionVarswarningsTests/IntegrationTests.lean: removes stalesimparguments (NodeOps.children,NodeOps.replaceChildren,NodeOps.mapChildren,hlen) fromreplaceChildren_childrenandreplaceChildren_sameShapeinstance proofs, eliminating ~20unusedSimpArgswarningsAfter this PR:
lake buildproduces zero warnings and zero errors.Test plan
lake build— zero warnings, zero errorslake exe integration-tests— 33/33 tests passed