Skip to content

feat: support plugin poll feature#744

Merged
WH-2099 merged 2 commits into
mainfrom
poll
May 21, 2026
Merged

feat: support plugin poll feature#744
WH-2099 merged 2 commits into
mainfrom
poll

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented May 21, 2026

Description

fix #743

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request go Pull requests that update go code plugin-daemon labels May 21, 2026
@fatelei fatelei changed the title Poll feat: support plugin poll feature May 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a polling mechanism for model interactions by adding new access actions, API endpoints, and service logic. It introduces ModelPollingResult with custom validation to ensure state consistency and adds corresponding request structures for starting and checking polling status. Reviewer feedback focuses on improving maintainability by replacing magic strings with constants for polling statuses and refining error messages for better debuggability.

Comment thread pkg/entities/model_entities/polling.go
Comment thread pkg/entities/model_entities/polling.go
Comment thread internal/core/io_tunnel/model_polling.go Outdated
@WH-2099 WH-2099 self-assigned this May 21, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 21, 2026
@WH-2099 WH-2099 merged commit 827d1ce into main May 21, 2026
7 checks passed
@WH-2099 WH-2099 deleted the poll branch May 21, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code lgtm This PR has been approved by a maintainer plugin-daemon size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin poll support

3 participants