fix(macros-core): update unstable proc_macro APIs for recent nightly#4227
Merged
abonander merged 1 commit intolaunchbadge:mainfrom Apr 14, 2026
Merged
Conversation
The unstable proc_macro tracking APIs were restructured in rust-lang/rust#149400: - modules `tracked_env` and `tracked_path` were merged into a single module `tracked` - `proc_macro::tracked_env::var` -> `proc_macro::tracked::env_var` - `proc_macro::tracked_path::path` -> `proc_macro::tracked::path` - features `track_path` -> `proc_macro_tracked_path` (+ `proc_macro_tracked_env`) Building with --cfg=sqlx_macros_unstable on recent nightly fails because of the renames and because `extern crate proc_macro;` was only declared in `migrate.rs`, leaving `lib.rs` and `query/cache.rs` without the crate in scope. Move the gated `extern crate proc_macro;` to the crate root, drop the duplicate from migrate.rs, and update the API call sites and the clippy.toml reason field. Fixes launchbadge#4150
Collaborator
|
Hopefully this means these APIs are on-track to being stabilized. It's been years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #4150
Is this a breaking change?
No. The change only touches code gated behind
#[cfg(any(sqlx_macros_unstable, procmacro2_semver_exempt))], which is opt-in and only compiles on nightly.The unstable proc_macro tracking APIs were restructured in rust-lang/rust#149400:
tracked_envandtracked_pathwere merged into a single moduletrackedproc_macro::tracked_env::var→proc_macro::tracked::env_var(note: also renamed fromvartoenv_var)proc_macro::tracked_path::path→proc_macro::tracked::pathtrack_path→proc_macro_tracked_path(+proc_macro_tracked_env)Building
sqlx-macros-corewith--cfg=sqlx_macros_unstableon recent nightly fails for two reasons:extern crate proc_macro;was declared only inmigrate.rs, soproc_macrowas not in scope fromlib.rs(line 99) orquery/cache.rs(line 74). The reporter only saw the rename error because the missing-crate error happens later in the compilation order.This PR moves the gated
extern crate proc_macro;to the crate root inlib.rs(so it's visible to all modules), drops the duplicate frommigrate.rs, and updates the four API call sites plus theclippy.tomlreason field.Verified locally on
nightly-2026-04-02:Stable also unaffected.
Drafted with AI assistance. I reviewed every change, reproduced the bug locally on nightly, and verified the fix.