Skip to content

chore: rm old references to devnet fork; rm exec fork refs#710

Merged
tcoratger merged 3 commits intoleanEthereum:mainfrom
fselmo:chore/fix-some-old-references
May 6, 2026
Merged

chore: rm old references to devnet fork; rm exec fork refs#710
tcoratger merged 3 commits intoleanEthereum:mainfrom
fselmo:chore/fix-some-old-references

Conversation

@fselmo
Copy link
Copy Markdown
Contributor

@fselmo fselmo commented May 5, 2026

🗒️ Description

  • feat(tooling): replace tox with just #709 caught and fixed some old references to --fork=devnet that were related to those changes. This PR aims to fix the remaining ones as they would've been out of context in that PR.
  • Remove references along the way for Shanghai as some potential future execution fork as that is out of scope for now.

Will wait until #709 is merged to rebase here and make sure all the remaining references are caught then mark as ready for review. [done]

✅ Checklist

  • Ran just checks to avoid unnecessary CI fails:
    just check
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

@tcoratger
Copy link
Copy Markdown
Collaborator

Thanks a lot @fselmo this is ready to merge no?

@fselmo fselmo force-pushed the chore/fix-some-old-references branch from 17ffc65 to e467e58 Compare May 6, 2026 20:50
@fselmo
Copy link
Copy Markdown
Contributor Author

fselmo commented May 6, 2026

Thanks a lot @fselmo this is ready to merge no?

I found a few more after rebasing... should be good to review now.

One q I had is how to address tests/consensus/devnet? This is based on "devnet fork" as the __init__.py docstring mentions. Did you want to rename this dir to lstar? Leave this alone for now or?

@fselmo fselmo marked this pull request as ready for review May 6, 2026 20:56
@tcoratger
Copy link
Copy Markdown
Collaborator

Thanks a lot @fselmo this is ready to merge no?

I found a few more after rebasing... should be good to review now.

One q I had is how to address tests/consensus/devnet? This is based on "devnet fork" as the __init__.py docstring mentions. Did you want to rename this dir to lstar? Leave this alone for now or?

Yes I think we can rename to lstar, do you want to group this into this PR?

@fselmo
Copy link
Copy Markdown
Contributor Author

fselmo commented May 6, 2026

Yes I think we can rename to lstar, do you want to group this into this PR?

Done 👍🏼

@tcoratger tcoratger merged commit a5a05f9 into leanEthereum:main May 6, 2026
13 checks passed
@fselmo fselmo deleted the chore/fix-some-old-references branch May 6, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants