Open
Conversation
sjaeckel
force-pushed
the
pr/argon2-rfc9106
branch
from
64f6745 to
458b392
Compare
* We continue using `LTC_ARGCHK()` until we've decided on something else. * Call the enum/struct the same as the typedef. * Some other small adjustments/fixes. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
reviewed
Apr 12, 2026
Member
sjaeckel
left a comment
sjaeckel
left a comment
There was a problem hiding this comment.
Basically LGTM!
Thanks a lot.
What do you think of my proposed changes?
Member
Author
|
Your changes are fine with me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Argon2 Memory-Hard Function for Password Hashing and Proof-of-Work Applications.
Follows RFC 9106 https://www.rfc-editor.org/rfc/rfc9106.html
Based on the public domain reference implementation from https://github.com/p-h-c/phc-winner-argon2 (switched to libtomcrypt's BLAKE2b implementation + libtomcrypt's macros)
Checklist