Draft
Conversation
5bfc364 to
6c580dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With
LineBotClient/AsyncLineBotClientestablished as the single entry point and all legacy code already marked@deprecatedin the previous PR, the v2linebotmodules are no longer needed. Removing them reduces the package size, eliminates confusion between two parallel APIs, and ensures new users only see the supported path.What's changed
Deleted
linebot/api.py,linebot/async_api.py— legacyLineBotApi/AsyncLineBotApiclasseslinebot/models/(26 files) — all v2 model classes (Action,FlexMessage,RichMenu,Template, etc.)linebot/constants/— v2 constantslinebot/http_client.py,linebot/async_http_client.py,linebot/aiohttp_async_http_client.py— v2 HTTP client layerlinebot/exceptions.py— v2BaseError,LineBotApiErrorlinebot/utils.py,linebot/webhook.py— v2 utilities and webhook (v3 has its own atlinebot/v3/webhook.py)linebot/deprecations.py— deprecation warning classes (no longer needed)tests/api/,tests/async_api/,tests/models/,tests/test_*.py,tests/text/— all v2 testsdocs/source/linebot.rst,docs/source/linebot.models.rst— v2 Sphinx docsModified
linebot/__init__.py— stripped down to only export__version__setup.py— removedCodegenCommand(generatedasync_api.pyfromapi.py) andsubprocessimportrequirements.txt— removedDeprecatedpackage dependencyREADME.rst— replaced "How to suppress deprecation warnings" section with a note that v2 modules have been removeddocs/source/index.rst— removedlinebotfrom toctree (onlylinebot.v3remains)