tests: give each integration test its own fixture directory#231
Open
igoropaniuk wants to merge 1 commit intolinux-msm:masterfrom
Open
tests: give each integration test its own fixture directory#231igoropaniuk wants to merge 1 commit intolinux-msm:masterfrom
igoropaniuk wants to merge 1 commit intolinux-msm:masterfrom
Conversation
test_flashmap.sh and test_vip_generation.sh both wrote fixtures to
${builddir}/tests/data, and meson runs the two tests in parallel.
Their generate_flat_build.sh invocations therefore raced on dd, cp
and the final `zip flashmap.zip ...`, while test_vip_generation.sh's
EXIT trap could rm -rf the directory out from under its peer.
The race was masked while zip took several seconds on the unshrunk
1 GB fixtures; once fixture generation dropped to ~30 ms it started
firing on the macos-14 arm64 runner as zip exit status 18 ("could
not open a specified file to read").
Point each test at its own directory (data-flashmap / data-vip) so
they no longer share mutable state.
Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_flashmap.sh and test_vip_generation.sh both wrote fixtures to ${builddir}/tests/data, and meson runs the two tests in parallel. Their generate_flat_build.sh invocations therefore raced on dd, cp and the final
zip flashmap.zip ..., while test_vip_generation.sh's EXIT trap could rm -rf the directory out from under its peer.The race was masked while zip took several seconds on the unshrunk 1 GB fixtures; once fixture generation dropped to ~30 ms it started firing on the macos-14 arm64 runner as zip exit status 18 ("could not open a specified file to read").
Point each test at its own directory (data-flashmap / data-vip) so they no longer share mutable state.