compat (fd): Adds cross-platform-compatible file descriptor type#3314
Closed
bgoing-micron-oss wants to merge 1 commit into
Closed
compat (fd): Adds cross-platform-compatible file descriptor type#3314bgoing-micron-oss wants to merge 1 commit into
bgoing-micron-oss wants to merge 1 commit into
Conversation
igaw
reviewed
May 13, 2026
Collaborator
|
Could you rebase and move the typedefs to lib-types.h? Rest looks good, not too much noise and code churn which is good news :) Thanks! |
Creates and uses new libnvme_fd_t to handle differences in file descriptor types across platforms. Also defines platform-specific values for invalid file descriptors and test file descriptors. Signed-off-by: Broc Going <bgoing@micron.com> Signed-off-by: Brandon Capener <bcapener@micron.com>
bgoing-micron-oss
force-pushed
the
bgoing/libnvme-fd-compatibility
branch
from
346c568 to
cc570ac
Compare
Collaborator
|
Same here, I tweaked the commit message slightly to use the different style for the prefix and applied it directly. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates and uses new libnvme_fd_t to handle differences in file descriptor types across platforms. Also defines platform-specific values for invalid file descriptors and test file descriptors.