nvme-models: suppress missing sysfs entry messages#3359
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to suppress error output when optional NVMe sysfs attributes are missing, addressing noisy failures in blktests for NVMe loop setups.
Changes:
- Updates
read_sys_node()to avoid printing an error for missing sysfs files. - Preserves existing failure return behavior when a sysfs node cannot be opened.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
blktests nvme/033 with tr=loop fails because read_sys_node() reports missing sysfs entries as errors. Some setups legitimately do not provide these attributes, so treat missing sysfs entries as optional and suppress the error messages. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blktests nvme/033 with tr=loop fails because read_sys_node() reports missing sysfs entries as errors.
Some setups legitimately do not provide these attributes, so treat missing sysfs entries as optional and suppress the error messages.
Fixes: #3358