micron-nvme cleanup#3364
Merged
igaw merged 5 commits intoMay 15, 2026
Merged
Conversation
Updates micron-nvme log buffers to use libnvme_alloc / libnvme_realloc / libnvme_free. Signed-off-by: Broc Going <bgoing@micron.com>
Fixes telemetry log reading failures caused by the wrong offset and size values being used. Improves error reporting. Signed-off-by: Broc Going <bgoing@micron.com>
Fixes format parameter validation logic, which was causing the command to always fail with "Invalid output format". Signed-off-by: Broc Going <bgoing@micron.com>
Removes duplicate id-ctrl and improves error reporting when no log can be read. Signed-off-by: Broc Going <bgoing@micron.com>
Fixes reporting of positive error values in several commands in the micron-nvme plugin. Cleans up error reporting of positive versus negative error codes by using nvme_show_err. Signed-off-by: Broc Going <bgoing@micron.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean-up and fixes for the Micron plugin.