refactor: use ansible.posix 2.1.X for EL7 compatibility#502
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the ansible.posix collection dependency to version 2.1.0 in collection-requirements to maintain EL7 compatibility. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief inline comment next to the pinned
ansible.posixversion explaining the EL7 compatibility reason so future maintainers understand why this specific version is required. - If possible, use a version range (e.g.,
<=2.1.0) instead of a hard pin to2.1.0so you can pick up compatible patch releases automatically while still avoiding 2.2.0 on EL7.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief inline comment next to the pinned `ansible.posix` version explaining the EL7 compatibility reason so future maintainers understand why this specific version is required.
- If possible, use a version range (e.g., `<=2.1.0`) instead of a hard pin to `2.1.0` so you can pick up compatible patch releases automatically while still avoiding 2.2.0 on EL7.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
060de72 to
0770657
Compare
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
The recently released ansible.posix 2.2.0 does not work on EL7. Pin the version of ansible.posix to 2.1.X. NOTE: Even though this role might not support EL7, this update is applied to all system roles for consistency. Plus, when this role is part of the system roles collection, all roles must use the same version of ansible.posix - there is no way for a role which is part of a collection to use a different version of a dependency than the version used by the other roles. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
0770657 to
b2717dd
Compare
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.