fix(agents): bypass AudioResampler when input and output sample rates…#1453
Open
KrishnaShuk wants to merge 2 commits into
Open
fix(agents): bypass AudioResampler when input and output sample rates…#1453KrishnaShuk wants to merge 2 commits into
KrishnaShuk wants to merge 2 commits into
Conversation
… match Fixes livekit#1431 by short-circuiting the AudioResampler logic locally when the input chunk sampleRate perfectly bounds with the STT outputRate preventing exhaustive runtime FFI overhead drops and rampant RSS memory leak inflation over long stream execution.
|
Contributor
|
@KrishnaShuk Can you confirm if it's working in a real agent session? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1431
Short-circuits the
AudioResamplerlogic natively in utils.ts when the incoming chunksampleRateperfectly matches the requestedoutputRate.This efficiently prevents exhaustive runtime FFI overhead instantiations and stops the runaway RSS memory padding up to several gigabytes over long streaming sessions.
Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
Note to reviewers: Please ensure the pre-review checklist is completed before starting your review.