Send ReadyForRoomEvent after Connect to flush queued room events#282
Open
MaxHeimbrock wants to merge 1 commit into
Open
Send ReadyForRoomEvent after Connect to flush queued room events#282MaxHeimbrock wants to merge 1 commit into
MaxHeimbrock wants to merge 1 commit into
Conversation
The Rust FFI now parks the connect task after sending ConnectCallback and only spawns event-forwarding tasks once the client sends ReadyForRoomEventRequest. Without it, room events emitted between Connect and the C# listener registration were dropped (late-join scenario), and on the new Rust SDK the room is closed with ConnectionTimeout after 1s. Room.OnConnect now sends the ready request immediately after subscribing to FfiClient.RoomEventReceived and before firing the public Connected event. Adds a PlayMode regression test that publishes 4 tracks before a subscriber joins late and asserts every TrackSubscribed event arrives exactly once. Proto bindings regenerated via Scripts~/generate_proto.sh against the new ffi.proto / room.proto. DataTrack.cs consumer updated for the DataTrackStreamEOS.error field type change (string -> message). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on: livekit/rust-sdks#1068 - have to check why this even passes one of the two test suites without.
Room.OnConnectnow sends the new FFIReadyForRoomEventRequestafter subscribing toFfiClient.RoomEventReceivedand before firing the publicConnectedevent, completing the new ready-handshake the Rust SDK requires.LateJoinTrackSubscriptionTests) that publishes 2 audio + 2 video tracks first, then connects a late joiner withTrackSubscribedpre-wired, and asserts every snapshot publication produces exactly oneTrackSubscribedevent.DataTrack.csfor theDataTrackStreamEOS.errorfield type change.Why
Without
ReadyForRoomEventRequest, room events emitted betweenConnectCallbackand the C# listener registration could be silently dropped — late joiners would missTrackSubscribed/ParticipantConnectedfor state that already existed at connect time. The new Rust contract (onclient-sdk-rustbranchladvoc/ffi-event-flush) makes this deterministic: the connect task parks for 1 s waiting forReadyForRoomEventRequestand disconnects the room withConnectionTimeoutif it never arrives. This PR ports that contract to the Unity SDK.Test plan
Scripts~/run_unity.sh test -m PlayMode -f LateJoinTrackSubscriptionTeststimed out waiting for ReadyForRoomEventRequest after ConnectCallbackDataTrackTests.*,FfiBoundaryTests.Disconnect_CalledTwice_DoesNotThrow) surfacing asFailed to open data track publish transport: connection error: closed— not introduced by this PR.Notes for reviewers
client-sdk-rustbranchladvoc/ffi-event-flushand must merge tomainbefore this PR's submodule pointer is updated and merged. Until then, this PR can be tested locally by checking out that branch inclient-sdk-rust~/and rebuilding the FFI dylib.ReadyForRoomEventrequest/response and the consumer fix inRuntime/Scripts/DataTrack.cs:393.🤖 Generated with Claude Code