Skip to content

Update readme for consistency#26

Open
jondkelley wants to merge 1 commit into
logdna:masterfrom
jondkelley:update-readme-for-consistency
Open

Update readme for consistency#26
jondkelley wants to merge 1 commit into
logdna:masterfrom
jondkelley:update-readme-for-consistency

Conversation

@jondkelley
Copy link
Copy Markdown

@jondkelley jondkelley commented Jan 20, 2021

Making slight modifications for better consistency across the doc

  • Removing quotes from readme. Quotes in cases like docker-compose are provided as literals and invalidate the config. Quotes are also only necessary in YaML if it will create type-aware objects such as integers or arrays.
  • Removing quotes from bash commands as they're not really required unless the value has spaces.
  • Removing single quotes from image name, not necessary.

Copy link
Copy Markdown

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jondkelley I am really not sure why those quotation marks were ever even there, single or double.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants