Tools specification#457
Draft
marnovandermaas wants to merge 2 commits into
Draft
Conversation
This adds a file called tool_data.json which specifies all the tools that we are dependent on. The commit also valides this against a standard schema defined here: https://github.com/marnovandermaas/tool-schema/blob/main/tool_schema.json
Collaborator
Author
|
@ziuziakowska mentioned that we should probably use a Python library to validate this: https://python-jsonschema.readthedocs.io/en/stable/validate/ |
engdoreis
reviewed
May 13, 2026
| gtkwave | ||
| openfpgaloader | ||
| openocd | ||
| nodejs |
Collaborator
There was a problem hiding this comment.
I'm not very keen on adding nodejs as a dependency only for the json schema validation. I suggesting using either python or compiled tools, a few options are:
- jsonschema-cli: a Rust binary and can be installed with nix.
- check-jsonschema: a Python script that can be installed with uv.
- Our own script based on opentitan json schema linter.
engdoreis
reviewed
May 13, 2026
Collaborator
engdoreis
left a comment
engdoreis
left a comment
There was a problem hiding this comment.
This is a good feature but I left a comment about the dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What tools do we need for Mocha and validate this against our schema.
Closes: #439