Added motor and current saturation to the led status bar#82
Conversation
fae1217 to
0d9be03
Compare
lukash
left a comment
There was a problem hiding this comment.
Thanks for this.
I was actually just recently thinking I should get to add the last led blinking when battery empty. Yes please definitely do that as a separate commit, it's independent from the motor utilization change. Could even go into a separate PR.
I'll have to find some time to do a full review, how determined are you to get this into 1.3? Should be possible... At first glance the code looks reasonable...
I'm not fussed, if I want these features I can just put them on my board myself.
Sounds good, I'll remove from this PR and create a new one. |
0d9be03 to
fae111a
Compare
fae111a to
fae1f2e
Compare
Feature: Motor and Current saturation are shown in the led status bar
Following up on this suggestion here: #44 (comment)
A couple things to align on before this is ready to merge:
should I split out the battery blinking into a separate commit +done in On low battery pulse a single red led #84feature:/ leave it as is / update the current commit message + trailer?I renamedrenamed tostatus_duty_blend -> status_blend, and alsoduty_threshold -> status_threshold, hope that's alrightstatus.motor_utilization_threshold