Haptic alerts for footpad sensors#83
Closed
acheronfail wants to merge 2 commits into
Closed
Conversation
fae1f70 to
fae13dc
Compare
Feature: new optional haptic alert for footpad sensors
fae13dc to
56bfc8c
Compare
56bfc8c to
386097c
Compare
Owner
|
I am planning on revamping the alerting altogether in 1.4 (via the Alert tracker) with the options to use beeper or haptic for each individual alert. Sensor alerts will be part of it. I don't think we can get this into 1.3, I don't want to inflate it too much. I'll have a closer look at your implementation later but my plan is to build the new alerting from the bottom up in a systematic way and not sure how your implementation will fit... |
Contributor
Author
|
Sweet - don't worry about this change then, if it's coming soon anyway that's not an issue. I'll just run this build on my one board with the not-so-sensitive foot sensors until 1.4 is out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm interested in your thoughts on this change. But basically it's adding haptic alerts when traveling at speed without one (or both) of the footpads being triggered. Use-cases:
For me, I'm more interested in the first use-case, since I have a board where one sensor only works in certain parts of the footpad, and I want alerts on it.
Some things for alignment: