add json tags to config structs for easier reuse#780
Open
dhontecillas wants to merge 1 commit intomasterfrom
Open
add json tags to config structs for easier reuse#780dhontecillas wants to merge 1 commit intomasterfrom
dhontecillas wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: David Hontecillas <dhontecillas@gmail.com>
dhontecillas
force-pushed
the
add_json_tags_in_config
branch
from
9dfc55e to
e280d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to reuse existing configuration structs, it could be useful to have the json tags set.
The
config/parser.gofile might also benefit for removing some structs, and use directly those structures. However, in order to avoid side effects or having to make a thorough testing of the changes, for now we only add the json tags.