feat: remove calendar buttons, add month, fix burger menu and update design#158
Open
carolinedplm wants to merge 26 commits intodevfrom
Open
feat: remove calendar buttons, add month, fix burger menu and update design#158carolinedplm wants to merge 26 commits intodevfrom
carolinedplm wants to merge 26 commits intodevfrom
Conversation
carolinedplm
changed the title
carolinedplm
force-pushed
the
fix/calendar
branch
from
26a7c57 to
7637a70
Compare
carolinedplm
changed the title
carolinedplm
commented
Jan 26, 2026
| <a class="navbar-item" href="mailto:contact@lyontechhub.org" title="Mail de contact"> | ||
| <span class="icon is-medium"><i class="fa fa-envelope fa-lg"></i></span> | ||
| </a> | ||
| <a class="navbar-item" href="https://groups.google.com/forum/#!forum/lyontechhub" title="Liste de discussion"> |
Contributor
Author
There was a problem hiding this comment.
enlever X et github
carolinedplm
force-pushed
the
fix/calendar
branch
from
7637a70 to
4f1cdea
Compare
carolinedplm
changed the title
carolinedplm
commented
Mar 31, 2026
|
|
||
| <h2>Référencer une communauté</h2> | ||
| <p> | ||
| Pour inscrire votre communauté, envoyez une <b>pull request sur GitHub</b> pour mettre en ligne les |
Contributor
Author
There was a problem hiding this comment.
toujours valable ?
Contributor
Author
|
bug sur le calendrier avec la popup décalée |
Contributor
Author
|
assurance evenementielle : changer le lien en contactez nous pour en savoir plus |
Contributor
Author
|
mettre plus en avant la cotisation : soutenez nous avec le lien par ex sur l'accueil dans "membre" |
…lists ICS feed URLs and descriptions are interpolated into popup HTML and the mobile/community event template. A javascript: URL or HTML in the description was executed as-is. Validate URLs via the URL constructor (http/https only) and HTML-escape every interpolated value.
The desktop calendar, the mobile list and the community pages each re-fetched and re-parsed the same ICS file. Cache the parsed event array in a module-scoped promise so repeated calls (prev/next clicks, both views on the same page) share one network request.
Rapid prev/next clicks on a slow connection could let an earlier fetch resolve after a newer one and overwrite the visible list with the wrong window. Snapshot windowStart per click into a fresh Date and use a render token so out-of-order resolves are dropped. Also switch the nav handlers from .onclick assignments to addEventListener.
Observing the whole #calendar subtree fired the position-fix callback on every Toast UI internal style write (drag highlights, day-cell hovers, layout reflows). Scope the observer to the floating-layer node where the popup is actually portalled; poll for it after init so it binds once the layer is in the DOM.
Events now pass state: '' which makes Toast UI skip the entire detail row (the lib's render is gated on the state being truthy). The CSS override that hid only the icon was carried over from when state was 'link' and is no longer needed.
The previous containment filter (start >= min && end <= max) dropped multi-day events that started inside the window but ended after it, e.g. a workshop spanning a weekend into the next two-week mobile slice. Switch to overlap semantics so any event intersecting the window shows up.
Intl.DateTimeFormat defaults to the visitor's local timezone, so a viewer in New York saw the popup time shifted by 6h. Force Europe/Paris on both formatters so the meetup time is always shown in Paris time.
popupDetailDate only formatted the start day so a 2-day workshop or an event ending past midnight appeared with just the start date and a time range that didn't make sense. When start and end fall on different days, render both as 'StartDate, HH:MM → EndDate, HH:MM'.
…uation slice(0, max) counts UTF-16 code units, so cutting on a 4-byte emoji boundary left a lone surrogate before the ellipsis. Spread the string into code points instead. Also strip trailing dots/spaces/ellipses before appending the ellipsis so a description ending in '...' no longer becomes '......'.
Aligns with the mobile nav handlers (already addEventListener-based) and avoids accidentally clobbering any future handler attached to the same element.
The matched ICS prefix kept whatever casing the source used (e.g. [afup] vs [AFUP]), which is inconsistent across events of the same community. Once we've matched a pattern, prepend the canonical pattern from communities.json instead of the captured one.
target="_blank" links to meetup.com etc. were leaking the referrer header. Add rel="noopener noreferrer" on the popup link and on the event-list anchor.
The chevron-only Previous/Next buttons had no accessible name; screen readers announced them as bare 'button'. Add aria-label on all four, mark the decorative FA icons aria-hidden, and translate the desktop 'Today' to 'Aujourd'hui' for lang=fr consistency. Wrap the date and range labels with aria-live=polite so updates are announced.
The brand red #eb0f0f on white was 4.07:1, just under AA's 4.5:1 threshold for normal text. Darken to #c00d0d (5.4:1) only on the popup link; the brand red stays as-is for non-text accents.
20px from .calendar-header was crowding the 4 buttons + range label on narrow viewports. Drop to 16px inside the mobile media query.
Member
Dans une autre MR, il faudrait revoir le build JS/CSS pour ne plus avoir les dépendances en dur, notamment. J'ai espoir que la mise à jour corrige des bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.