Skip to content

fix: use patched svm crate for privileged access control#1225

Draft
bmuddha wants to merge 4 commits into
masterfrom
bmuddha/fix/tighten-privileged-access
Draft

fix: use patched svm crate for privileged access control#1225
bmuddha wants to merge 4 commits into
masterfrom
bmuddha/fix/tighten-privileged-access

Conversation

@bmuddha
Copy link
Copy Markdown
Collaborator

@bmuddha bmuddha commented May 19, 2026

Summary by CodeRabbit

  • New Features

    • Added a new development tool to the workspace.
  • Bug Fixes

    • Acknowledgments are now sent only after successful writes to improve message reliability.
    • Service shutdown handling reordered to prioritize cancellation events for cleaner termination.
    • Adjusted nested-instruction account permission handling to reduce unnecessary writable access.
  • Chores

    • Updated Solana-related dependencies and refined workspace configuration.

Review Change Stack

@bmuddha bmuddha marked this pull request as draft May 19, 2026 13:19
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • test-integration/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b40a12b9-3846-4b7f-a97a-4f959d69bd5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates root and test-integration Cargo.toml files to use the Solana git branch bmuddha/fix/tighten-privileged-access-v3 (replacing v3), adds tools/magicblock-tui-client to workspace.members, and reforms dependency feature formatting. In runtime code, standby prioritizes shutdown earlier in tokio::select! and only acknowledges NATS block messages when block writes succeed; nested instruction program_id metas are now readonly.

Suggested reviewers

  • thlorenz
  • GabrielePicco
  • taco-paco
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bmuddha/fix/tighten-privileged-access

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmuddha bmuddha force-pushed the bmuddha/fix/tighten-privileged-access branch from afeb3a5 to 8089da9 Compare May 20, 2026 14:43
@bmuddha bmuddha force-pushed the bmuddha/fix/tighten-privileged-access branch from 8089da9 to 7809155 Compare May 20, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant