fix(database-pgsql): JSON-encode array bindings before passing to PDO#72
Open
michalbiarda wants to merge 1 commit into
Open
fix(database-pgsql): JSON-encode array bindings before passing to PDO#72michalbiarda wants to merge 1 commit into
michalbiarda wants to merge 1 commit into
Conversation
PDO silently casts PHP arrays to the string "Array" when bound as query parameters. For json/jsonb columns this causes an "invalid input syntax for type json" error at the database level. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
Summary
PgSqlConnection::bindValues()and calljson_encode()before binding, sojson/jsonbcolumns receive a valid JSON string instead of the literal"Array"Test plan
./vendor/bin/pest packages/database-pgsql/tests/Connection/PgSqlConnectionTest.php— all 29 tests pass including the new one🤖 Generated with Claude Code