fix(database): link entity extenders at boot so companions hydrate during HTTP requests#74
Open
michalbiarda wants to merge 1 commit into
Open
Conversation
…ring HTTP requests EntityMetadataFactory is now a singleton and a boot callback discovers all entity classes and calls linkExtendersFrom() so extender metadata is populated before any repository hydration occurs. Previously linkExtenders() was only called from CLI migration commands, leaving companions unattached at runtime. Closes marko-php#73 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntityMetadataFactorywas not registered as a singleton — every resolution created a fresh instance with an empty cachelinkExtenders()was only called fromSchemaRegistry::registerEntities(), which is invoked exclusively by CLI migration commands (DiffCommand,MigrateCommand)$metadata->extenderswas always[], soEntityHydratornever attached companion entitiesFix
EntityMetadataFactoryas a singleton inmodule.phpbootcallback that discovers all entity classes across vendor, modules, and app, then callslinkExtendersFrom()to populate the extender map once at startuplinkExtendersFrom()throws a loudEntityExceptionif an extender references a parent class that cannot be autoloaded, rather than silently ignoring the misconfigurationTest plan
linkExtendersFromscans entity classes and links extenders to their parentslinkExtendersFromignores entities withoutextendslinkExtendersFromthrowsEntityExceptionwhen an extender's parent class cannot be autoloadedcomposer testCloses #73
🤖 Generated with Claude Code